LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: next-20081030: voyager compile busted
Date: Thu, 30 Oct 2008 21:52:30 +0100	[thread overview]
Message-ID: <20081030205230.GO27407@elte.hu> (raw)
In-Reply-To: <1225398287.19324.1.camel@localhost.localdomain>


* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Thu, 2008-10-30 at 21:03 +0300, Alexey Dobriyan wrote:
> > On i386-voyager:
> > 
> >   Using /src/linux-1 as source for kernel
> >   GEN     /src/build/i386-voyager/Makefile
> >   CHK     include/linux/version.h
> >   CHK     include/linux/utsrelease.h
> >   SYMLINK include/asm -> include/asm-x86
> >   CALL    scripts/checksyscalls.sh
> >   CHK     include/linux/compile.h
> >   CC      arch/x86/kernel/tsc.o
> > arch/x86/kernel/tsc.c: In function 'unsynchronized_tsc':
> > arch/x86/kernel/tsc.c:763: error: implicit declaration of function 'apic_is_clustered_box'
> > make[2]: *** [arch/x86/kernel/tsc.o] Error 1
> >   CC      arch/x86/kernel/cpu/addon_cpuid_features.o
> > arch/x86/kernel/cpu/addon_cpuid_features.c: In function 'detect_extended_topology':
> > arch/x86/kernel/cpu/addon_cpuid_features.c:120: error: implicit declaration of function 'phys_pkg_id'
> > make[3]: *** [arch/x86/kernel/cpu/addon_cpuid_features.o] Error 1
> > make[3]: Target `__build' not remade because of errors.
> > make[2]: *** [arch/x86/kernel/cpu] Error 2
> > make[2]: Target `__build' not remade because of errors.
> > make[1]: *** [arch/x86/kernel] Error 2
> >   CC      arch/x86/mach-voyager/setup.o
> > arch/x86/mach-voyager/setup.c: In function 'intr_init_hook':
> > arch/x86/mach-voyager/setup.c:30: error: implicit declaration of function 'smp_intr_init'
> > arch/x86/mach-voyager/setup.c: In function 'machine_specific_memory_setup':
> > arch/x86/mach-voyager/setup.c:65: warning: unused variable 'new_nr'
> > make[2]: *** [arch/x86/mach-voyager/setup.o] Error 1
> >   CC      arch/x86/mach-voyager/voyager_smp.o
> > arch/x86/mach-voyager/voyager_smp.c:67: error: conflicting types for 'phys_cpu_present_map'
> > arch/x86/include/asm/mpspec.h:143: error: previous declaration of 'phys_cpu_present_map' was here
> > arch/x86/mach-voyager/voyager_smp.c: In function 'start_secondary':
> > arch/x86/mach-voyager/voyager_smp.c:444: error: implicit declaration of function 'notify_cpu_starting'
> > arch/x86/mach-voyager/voyager_smp.c: In function 'smp_call_function_interrupt':
> > arch/x86/mach-voyager/voyager_smp.c:955: error: implicit declaration of function 'generic_smp_call_function_interrupt'
> > arch/x86/mach-voyager/voyager_smp.c: In function 'smp_call_function_single_interrupt':
> > arch/x86/mach-voyager/voyager_smp.c:963: error: implicit declaration of function 'generic_smp_call_function_single_interrupt'
> > make[2]: *** [arch/x86/mach-voyager/voyager_smp.o] Error 1
> > make[2]: Target `__build' not remade because of errors.
> > make[1]: *** [arch/x86/mach-voyager] Error 2
> 
> Yes ... present in the 2.6.28-rc as well.  I've got it all fixed up
> locally.
>
> This type of breakage is more or less expected given that I wait 
> until -rc1 for the tree to stop churning before trying to fix 
> voyager and the subarchitectures, and the fact that the current way 
> x86 is being developed tends to break them.

one problem is the number of x86/Voyager testboxes - how many of them 
is there in existence - one or two, all of them owned by you?

the other problem is that you are apparently checking whether 
x86/Voyager builds (boots?) at all only once every couple of months - 
once per kernel cycle or so. That obviously means you'll be affected 
by an accumulated set of bugs. Nobody else _can_ test it instead of 
you, because no other kernel hacker owns this hardware.

So ... the right long-term way out of this is to do what we did with 
all the other x86 subarchitectures: to convert Voyager into a generic 
platform, via extension of the x86_quirks interfaces. That way we can 
remove the remainder of the fragile "x86 subarchitecture" concept. 
(which should never have been added to begin with)

Would you be interested in helping us out with such a project? It 
would be a nice cleanup for sure.

	Ingo

  reply	other threads:[~2008-10-30 20:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30  6:30 linux-next: Tree for October 30 Stephen Rothwell
2008-10-30 18:03 ` next-20081030: voyager compile busted Alexey Dobriyan
2008-10-30 20:24   ` James Bottomley
2008-10-30 20:52     ` Ingo Molnar [this message]
2008-10-30 20:58       ` James Bottomley
2008-10-30 21:07         ` Ingo Molnar
2008-10-30 21:21           ` James Bottomley
2008-10-30 21:42             ` H. Peter Anvin
2008-10-30 21:47               ` James Bottomley
2008-10-30 21:50                 ` H. Peter Anvin
2008-10-30 22:40                   ` Ingo Molnar
2008-10-31 17:42                     ` James Bottomley
2008-10-30 21:24       ` Alexey Dobriyan
2008-10-30 23:42   ` Tony Breeds
2008-10-30 23:55 ` linux-next: Tree for October 30 Randy Dunlap
2008-10-31  6:25   ` Greg KH
2008-10-31 16:40     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030205230.GO27407@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=adobriyan@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    --subject='Re: next-20081030: voyager compile busted' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).