LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] fix compile breakage casued by x86: move prefill_possible_map calling early
@ 2008-10-30 21:28 James Bottomley
  2008-10-30 21:56 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: James Bottomley @ 2008-10-30 21:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Yinghai Lu

>From 2947cdda39c36e5a0d56fe0c6b70a17526abb5b5 Mon Sep 17 00:00:00 2001
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Thu, 30 Oct 2008 15:51:22 -0500
Subject: [VOYAGER] add prefill_possible_mask() to fix linker breakage

Before

commit 329513a35d1a2b6b28d54f5c2c0dde4face8200b
Author: Yinghai Lu <yhlu.kernel@gmail.com>
Date:   Wed Jul 2 18:54:40 2008 -0700

    x86: move prefill_possible_map calling early

prefill_possible_mask() was hidden under CONFIG_HOTPLUG_CPU rendering
it invisitble to voyager.  Since this commit it's exposed, but not
provided by the voyager subarch, so add a dummy stub to fix the link
breakage.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
 arch/x86/mach-voyager/voyager_smp.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/x86/mach-voyager/voyager_smp.c b/arch/x86/mach-voyager/voyager_smp.c
index 761d491..ece93b1 100644
--- a/arch/x86/mach-voyager/voyager_smp.c
+++ b/arch/x86/mach-voyager/voyager_smp.c
@@ -346,6 +346,12 @@ static void do_quad_bootstrap(void)
 	}
 }
 
+void prefill_possible_map(void)
+{
+	/* This is empty on voyager because we need a much
+	 * earlier detection which is done in find_smp_config */
+}
+
 /* Set up all the basic stuff: read the SMP config and make all the
  * SMP information reflect only the boot cpu.  All others will be
  * brought on-line later. */
-- 
1.5.6.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix compile breakage casued by x86: move prefill_possible_map calling early
  2008-10-30 21:28 [PATCH] fix compile breakage casued by x86: move prefill_possible_map calling early James Bottomley
@ 2008-10-30 21:56 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-30 21:56 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-kernel, Yinghai Lu


* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> >From 2947cdda39c36e5a0d56fe0c6b70a17526abb5b5 Mon Sep 17 00:00:00 2001
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
> Date: Thu, 30 Oct 2008 15:51:22 -0500
> Subject: [VOYAGER] add prefill_possible_mask() to fix linker breakage
> 
> Before
> 
> commit 329513a35d1a2b6b28d54f5c2c0dde4face8200b
> Author: Yinghai Lu <yhlu.kernel@gmail.com>
> Date:   Wed Jul 2 18:54:40 2008 -0700
> 
>     x86: move prefill_possible_map calling early
> 
> prefill_possible_mask() was hidden under CONFIG_HOTPLUG_CPU rendering
> it invisitble to voyager.  Since this commit it's exposed, but not
> provided by the voyager subarch, so add a dummy stub to fix the link
> breakage.
> 
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> ---
>  arch/x86/mach-voyager/voyager_smp.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

applied to tip/x86/urgent, thanks James!

these kinds of problems will go away too when x86/Voyager becomes part 
of the regular platform code.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-30 21:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-30 21:28 [PATCH] fix compile breakage casued by x86: move prefill_possible_map calling early James Bottomley
2008-10-30 21:56 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).