LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Jens Axboe <Jens.Axboe@oracle.com>
Subject: Re: [PATCH] fix smp generic helper voyager breakage
Date: Thu, 30 Oct 2008 23:21:11 +0100	[thread overview]
Message-ID: <20081030222111.GA18600@elte.hu> (raw)
In-Reply-To: <1225404368.19324.49.camel@localhost.localdomain>


* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Thu, 2008-10-30 at 22:54 +0100, Ingo Molnar wrote:
> > * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > 
> > > +++ b/arch/x86/Kconfig
> > > @@ -167,9 +167,11 @@ config GENERIC_PENDING_IRQ
> > >  config X86_SMP
> > >  	bool
> > >  	depends on SMP && ((X86_32 && !X86_VOYAGER) || X86_64)
> > > -	select USE_GENERIC_SMP_HELPERS
> > >  	default y
> > >  
> > > +config USE_GENERIC_SMP_HELPERS
> > > +	def_bool y
> > > +
> > 
> > uhm, that's a bogus change - USE_GENERIC_SMP_HELPERS must not be set 
> > on UP. This will break all UP compilations, on all x86 UP boxes:
> 
> Heh, that would be one thing I don't build in my test rig.

lets put it this way: that change, when put in my test rig, already 
broke more x86 boxes than there are working Voyager test-boxes in 
existence ;-) [it broke the build on three of them]

> > kernel/softirq.c: In function '__try_remote_softirq':
> > kernel/softirq.c:522: error: implicit declaration of function '__smp_call_function_single'
> > 
> > so i've removed your patch for now.
> 
> OK, I'll update it ... I assume it should depend on CONFIG_SMP then?

correct.

	Ingo

  reply	other threads:[~2008-10-30 22:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 21:09 James Bottomley
2008-10-30 21:20 ` Ingo Molnar
2008-10-30 21:54 ` Ingo Molnar
2008-10-30 22:06   ` James Bottomley
2008-10-30 22:21     ` Ingo Molnar [this message]
2008-11-09 17:53       ` James Bottomley
2008-11-10  9:35         ` Ingo Molnar
2008-11-10  9:41           ` Yinghai Lu
2008-11-10 14:20           ` James Bottomley
2008-11-11 11:09         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030222111.GA18600@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Jens.Axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] fix smp generic helper voyager breakage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).