LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Steve French <smfrench@gmail.com>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: mmotm 2008-10-30-02-23 uploaded (cifs)
Date: Fri, 31 Oct 2008 06:44:55 -0400	[thread overview]
Message-ID: <20081031064455.29eb2285@tleilax.poochiereds.net> (raw)
In-Reply-To: <490A8C16.6040207@oracle.com>

On Thu, 30 Oct 2008 21:39:50 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Steve French wrote:
> > On Thu, Oct 30, 2008 at 8:14 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >> On Thu, 30 Oct 2008 02:24:25 -0700 akpm@linux-foundation.org wrote:
> >>
> >>> The mm-of-the-moment snapshot 2008-10-30-02-23 has been uploaded to
> >>>
> >>>    http://userweb.kernel.org/~akpm/mmotm/
> >>>
> >>> It contains the following patches against 2.6.28-rc2:
> >> fs/cifs/connect.c: In function 'cifs_mount':
> >> fs/cifs/connect.c:2180: error: request for member 'sin_addr' in something not a structure or union
> >>
> >> rand-config attached.
> > 
> > These line numbers don't match anywhere close to what I expect to find
> > in -mm based on the contents of fs/cifs in cifs-2.6.git tree.  My
> > guess is that has a cifs patch from Jeff Layton, not in cifs-2.6.git
> > which may have other dependencies, and in any case IIRC has since been
> > removed from -mm but if not that patch may be the problem.
> > 
> > The closest line I have is:
> > 
> > 			sprintf(pSesInfo->serverName, "%u.%u.%u.%u",
> > 				NIPQUAD(sin_server.sin_addr.s_addr));
> > 
> > and since sin_server is defined as
> >    	struct sockaddr_in sin_server;
> > that should be fine.
> 
> I can't tell you whether this is in cifs.git, but the erring lines are:
> 
> 		tcon =
> 		    find_unc(sin_server.sin_addr.s_addr, volume_info.UNC,
> 			     volume_info.username);
> 
> where sin_server.sin_addr should be sin_server->sin_addr.
> 
> HTH.

This looks like a goof on my part. I have a later patch in this series
that eliminates that call. In an earlier patch series, these patches
were in reverse order and I neglected to fix this when I reordered the
series.

I think Andrew ended up dropping this patch from -mm for the time
being. It's going to need modification anyway due to other changes, so
it's probably best that it find its way to mainline via his tree.

Thanks,
-- 
Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2008-10-31 10:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200810300924.m9U9OPqK030938@imap1.linux-foundation.org>
2008-10-31  0:27 ` mmotm 2008-10-30-02-23 uploaded (mm/ + fs/) Randy Dunlap
2008-10-31  0:48   ` Andrew Morton
2008-10-31  1:14 ` mmotm 2008-10-30-02-23 uploaded (cifs) Randy Dunlap
2008-10-31  3:13   ` Steve French
2008-10-31  4:39     ` Randy Dunlap
2008-10-31 10:44       ` Jeff Layton [this message]
2008-10-31  1:19 ` mmotm 2008-10-30-02-23 uploaded (ad7879) Randy Dunlap
2008-10-31  1:23 ` mmotm 2008-10-30-02-23 uploaded (smc-ultra) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081031064455.29eb2285@tleilax.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=smfrench@gmail.com \
    --subject='Re: mmotm 2008-10-30-02-23 uploaded (cifs)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).