LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch] x86: Kill bogus MTRR warning when running under vmware
@ 2008-10-31 21:03 Chuck Ebbert
  2008-11-03  8:48 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Chuck Ebbert @ 2008-10-31 21:03 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Yinghai Lu, linux-kernel

x86: Kill bogus MTRR warning when running under vmware

The warning is suppressed when running under KVM, but VMware
guests also have empty MTRRs.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=468845

Signed-off-by: Chuck Ebbert <cebbert@redhat.com>

Index: linux-2.6.27.noarch/arch/x86/kernel/cpu/mtrr/main.c
===================================================================
--- linux-2.6.27.noarch.orig/arch/x86/kernel/cpu/mtrr/main.c
+++ linux-2.6.27.noarch/arch/x86/kernel/cpu/mtrr/main.c
@@ -1495,11 +1495,8 @@ int __init mtrr_trim_uncached_memory(uns
 	}
 
 	/* kvm/qemu doesn't have mtrr set right, don't trim them all */
-	if (!highest_pfn) {
-		WARN(!kvm_para_available(), KERN_WARNING
-				"WARNING: strange, CPU MTRRs all blank?\n");
+	if (!highest_pfn)
 		return 0;
-	}
 
 	/* check entries number */
 	memset(num, 0, sizeof(num));

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] x86: Kill bogus MTRR warning when running under vmware
  2008-10-31 21:03 [patch] x86: Kill bogus MTRR warning when running under vmware Chuck Ebbert
@ 2008-11-03  8:48 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-03  8:48 UTC (permalink / raw)
  To: Chuck Ebbert; +Cc: Yinghai Lu, linux-kernel, H. Peter Anvin


* Chuck Ebbert <cebbert@redhat.com> wrote:

> x86: Kill bogus MTRR warning when running under vmware
> 
> The warning is suppressed when running under KVM, but VMware
> guests also have empty MTRRs.
> 
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=468845

we are working on proper "are we within vmware" detection support. 
Patches already exist and it is useful to know it for other reasons as 
wel.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-03  8:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-31 21:03 [patch] x86: Kill bogus MTRR warning when running under vmware Chuck Ebbert
2008-11-03  8:48 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).