LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Johann Felix Soden <johfel@gmx.de>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module
Date: Fri, 31 Oct 2008 16:40:24 -0400	[thread overview]
Message-ID: <20081031204024.GB3109@redhat.com> (raw)
In-Reply-To: <1225403079.7328.7.camel@localhost>

On Thu, Oct 30, 2008 at 10:44:39PM +0100, Johann Felix Soden wrote:
> From: Johann Felix Soden <johfel@users.sourceforge.net>
> 
> The 'ret' variable is assigned, but not used in the return statement. Fix this.
> 
> Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
> CC: Jason Baron <jbaron@redhat.com>
> ---
>  lib/dynamic_printk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
> index d83660f..d0fd0e4 100644
> --- a/lib/dynamic_printk.c
> +++ b/lib/dynamic_printk.c
> @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
>  	nr_entries--;
>  out:
>  	up(&debug_list_mutex);
> -	return 0;
> +	return ret;
>  }
>  EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
>  

looks good to me.

Acked-by: Jason Baron <jbaron@redhat.com>

thanks,

-Jason

      reply	other threads:[~2008-10-31 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 21:44 Johann Felix Soden
2008-10-31 20:40 ` Jason Baron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081031204024.GB3109@redhat.com \
    --to=jbaron@redhat.com \
    --cc=gregkh@suse.de \
    --cc=johfel@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] driver core: Use '\''ret'\'' variable in unregister_dynamic_debug_module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).