LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module
@ 2008-10-30 21:44 Johann Felix Soden
2008-10-31 20:40 ` Jason Baron
0 siblings, 1 reply; 2+ messages in thread
From: Johann Felix Soden @ 2008-10-30 21:44 UTC (permalink / raw)
To: gregkh; +Cc: jbaron, linux-kernel
From: Johann Felix Soden <johfel@users.sourceforge.net>
The 'ret' variable is assigned, but not used in the return statement. Fix this.
Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
CC: Jason Baron <jbaron@redhat.com>
---
lib/dynamic_printk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
index d83660f..d0fd0e4 100644
--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
nr_entries--;
out:
up(&debug_list_mutex);
- return 0;
+ return ret;
}
EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
--
1.5.6.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module
2008-10-30 21:44 [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module Johann Felix Soden
@ 2008-10-31 20:40 ` Jason Baron
0 siblings, 0 replies; 2+ messages in thread
From: Jason Baron @ 2008-10-31 20:40 UTC (permalink / raw)
To: Johann Felix Soden; +Cc: gregkh, linux-kernel
On Thu, Oct 30, 2008 at 10:44:39PM +0100, Johann Felix Soden wrote:
> From: Johann Felix Soden <johfel@users.sourceforge.net>
>
> The 'ret' variable is assigned, but not used in the return statement. Fix this.
>
> Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
> CC: Jason Baron <jbaron@redhat.com>
> ---
> lib/dynamic_printk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
> index d83660f..d0fd0e4 100644
> --- a/lib/dynamic_printk.c
> +++ b/lib/dynamic_printk.c
> @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
> nr_entries--;
> out:
> up(&debug_list_mutex);
> - return 0;
> + return ret;
> }
> EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
>
looks good to me.
Acked-by: Jason Baron <jbaron@redhat.com>
thanks,
-Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-31 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-30 21:44 [PATCH] driver core: Use 'ret' variable in unregister_dynamic_debug_module Johann Felix Soden
2008-10-31 20:40 ` Jason Baron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).