LKML Archive on
help / color / mirror / Atom feed
From: Alexey Dobriyan <>
To: Al Viro <>
Subject: Re: [PATCH] el3_common_init() should be __devinit, not __init
Date: Sat, 1 Nov 2008 22:12:50 +0300	[thread overview]
Message-ID: <20081101191250.GA7588@x200.localdomain> (raw)
In-Reply-To: <>

On Sat, Nov 01, 2008 at 06:20:19PM +0000, Al Viro wrote:
> -static int __init el3_common_init(struct net_device *dev)
> +static int __devinit el3_common_init(struct net_device *dev)

Al, here is much better patch:

--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -83,20 +83,20 @@
 #define __exit          __section(.exit.text) __exitused __cold
 /* Used for HOTPLUG */
-#define __devinit        __section(.devinit.text) __cold
-#define __devinitdata    __section(
-#define __devinitconst   __section(.devinit.rodata)
-#define __devexit        __section(.devexit.text) __exitused __cold
-#define __devexitdata    __section(
-#define __devexitconst   __section(.devexit.rodata)
+#define __devinit        __cold
+#define __devinitdata
+#define __devinitconst
+#define __devexit        __exitused __cold
+#define __devexitdata
+#define __devexitconst
 /* Used for HOTPLUG_CPU */
-#define __cpuinit        __section(.cpuinit.text) __cold
-#define __cpuinitdata    __section(
-#define __cpuinitconst   __section(.cpuinit.rodata)
-#define __cpuexit        __section(.cpuexit.text) __exitused __cold
-#define __cpuexitdata    __section(
-#define __cpuexitconst   __section(.cpuexit.rodata)
+#define __cpuinit        __cold
+#define __cpuinitdata
+#define __cpuinitconst
+#define __cpuexit        __cold
+#define __cpuexitdata
+#define __cpuexitconst
 /* Used for MEMORY_HOTPLUG */
 #define __meminit        __section(.meminit.text) __cold
@@ -115,13 +115,13 @@
 #define __INITRODATA	.section	".init.rodata","a"
 #define __FINITDATA	.previous
-#define __DEVINIT        .section	".devinit.text", "ax"
-#define __DEVINITDATA    .section	"", "aw"
-#define __DEVINITRODATA  .section	".devinit.rodata", "a"
+#define __DEVINIT
+#define __DEVINITDATA
-#define __CPUINIT        .section	".cpuinit.text", "ax"
-#define __CPUINITDATA    .section	"", "aw"
-#define __CPUINITRODATA  .section	".cpuinit.rodata", "a"
+#define __CPUINIT
+#define __CPUINITDATA
 #define __MEMINIT        .section	".meminit.text", "ax"
 #define __MEMINITDATA    .section	"", "aw"

  reply	other threads:[~2008-11-01 19:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-01 18:20 Al Viro
2008-11-01 19:12 ` Alexey Dobriyan [this message]
2008-11-01 19:16   ` Al Viro
2008-11-01 19:27     ` Alexey Dobriyan
2008-11-01 19:32       ` Al Viro
2008-11-01 21:17       ` Sam Ravnborg
2008-11-02 18:13         ` Linus Torvalds
2008-11-02 18:47           ` Al Viro
2008-11-02 20:31           ` Sam Ravnborg
2008-11-06  5:42 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081101191250.GA7588@x200.localdomain \ \ \ \ \ \
    --subject='Re: [PATCH] el3_common_init() should be __devinit, not __init' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).