LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Al Viro <viro@ftp.linux.org.uk>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
jgarzik@pobox.com
Subject: Re: [PATCH] el3_common_init() should be __devinit, not __init
Date: Sat, 1 Nov 2008 22:27:57 +0300 [thread overview]
Message-ID: <20081101192757.GA7622@x200.localdomain> (raw)
In-Reply-To: <20081101191614.GA28946@ZenIV.linux.org.uk>
On Sat, Nov 01, 2008 at 07:16:14PM +0000, Al Viro wrote:
> On Sat, Nov 01, 2008 at 10:12:50PM +0300, Alexey Dobriyan wrote:
> > On Sat, Nov 01, 2008 at 06:20:19PM +0000, Al Viro wrote:
> > > -static int __init el3_common_init(struct net_device *dev)
> > > +static int __devinit el3_common_init(struct net_device *dev)
> >
> > Al, here is much better patch:
>
> [essentially kill devinit/cpuinit]
>
> What the hell makes it better?
Wasting efforts for too little gain?
More or less every distro enables HOTPLUG and HOTPLUG_CPU.
next prev parent reply other threads:[~2008-11-01 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 18:20 Al Viro
2008-11-01 19:12 ` Alexey Dobriyan
2008-11-01 19:16 ` Al Viro
2008-11-01 19:27 ` Alexey Dobriyan [this message]
2008-11-01 19:32 ` Al Viro
2008-11-01 21:17 ` Sam Ravnborg
2008-11-02 18:13 ` Linus Torvalds
2008-11-02 18:47 ` Al Viro
2008-11-02 20:31 ` Sam Ravnborg
2008-11-06 5:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081101192757.GA7622@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=viro@ftp.linux.org.uk \
--subject='Re: [PATCH] el3_common_init() should be __devinit, not __init' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).