Re: [RESEND] benet: BladeEngine 10Gb NIC driver

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Jeff Garzik]

Subbu Seetharaman wrote:
> Jeff,
> 
> It is more than two months since the benet driver patch was made available as a single file as suggeted by you :
> 
> ftp://ftp.serverengines.com/0001.benet.patch
> 
> I have not seen this applied.  Is there any reason for not applying this  patch ?  Do you want a patch against the latest git tree ?

The overall consensus at this year's Linux Kernel Summit was that this 
driver still needs a lot of cleanup, so I'm gonna try an experiment and 
stick this in the staging tree (currently jgarzik/netdev-2.6.git#benet).

Greg, do I need to do anything beyond simply putting it into the 
directory?  Do I need to add some code to taint, perhaps?

	Jeff

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Sun, Nov 02, 2008 at 08:15:15AM -0500, Jeff Garzik wrote:
> Subbu Seetharaman wrote:
>> Jeff,
>> It is more than two months since the benet driver patch was made available 
>> as a single file as suggeted by you :
>> ftp://ftp.serverengines.com/0001.benet.patch
>> I have not seen this applied.  Is there any reason for not applying this  
>> patch ?  Do you want a patch against the latest git tree ?
>
> The overall consensus at this year's Linux Kernel Summit was that this 
> driver still needs a lot of cleanup, so I'm gonna try an experiment and 
> stick this in the staging tree (currently jgarzik/netdev-2.6.git#benet).
>
> Greg, do I need to do anything beyond simply putting it into the directory? 
>  Do I need to add some code to taint, perhaps?

Anything in the drivers/staging/ directory tree will automatically get
the TAINT_CRAP flag applied to it, so there should not be any need to do
anything else for this.

But, if you want, I can take this, to handle any Kconfig and Makefile
merges that are probably going to be necessary do to me also adding new
drivers in my staging tree.  If so, feel free to send me the patch.

thanks,

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Tue, Nov 04, 2008 at 12:41:36PM +0200, Ilpo Järvinen wrote:
> On Mon, 3 Nov 2008, Greg KH wrote:
> 
> > Hm, call me extreemly stupid, but I don't see anything in that branch
> > for this driver.
> > 
> > Here's what I did:
> >   git fetch git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git benet master:jeff
> 
> I suppose you'd have needed instead of "benet master:jeff" just:
> 
> benet:jeff
> 
> Ie., from benet remote branch to jeff local branch (remote from the given
> repository obviously). ...Then you have that jeff branch and can checkout 
> it.

Ah, thanks, I'll try that next time.

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Ilpo Järvinen]

On Mon, 3 Nov 2008, Greg KH wrote:

> Hm, call me extreemly stupid, but I don't see anything in that branch
> for this driver.
> 
> Here's what I did:
>   git fetch git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git benet master:jeff

I suppose you'd have needed instead of "benet master:jeff" just:

benet:jeff

Ie., from benet remote branch to jeff local branch (remote from the given
repository obviously). ...Then you have that jeff branch and can checkout 
it.

-- 
 i.

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Mon, Nov 03, 2008 at 03:55:25PM -0500, Jeff Garzik wrote:
> Greg KH wrote:
>> Ok, that worked just fine, sorry for the noise, I was trying to be
>
> Cool...
>
>
>> "nice" and not use 'git pull' and use 'git fetch' like I thought I was
>> supposed to be doing :)
>
> Curious...  does "nice" mean nicer to the server, i.e. less expensive and 
> faster to calculate a download?

No, sorry, "nice" on my side so that a merge would not happen, just a
fetch, so I could see the patches and not have to worry about any merge
issues.

thanks,

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Jeff Garzik]

Greg KH wrote:
> Ok, that worked just fine, sorry for the noise, I was trying to be

Cool...


> "nice" and not use 'git pull' and use 'git fetch' like I thought I was
> supposed to be doing :)

Curious...  does "nice" mean nicer to the server, i.e. less expensive 
and faster to calculate a download?

	Jeff

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Mon, Nov 03, 2008 at 03:42:28PM -0500, Jeff Garzik wrote:
> Greg KH wrote:
>> On Mon, Nov 03, 2008 at 02:52:07PM -0500, Jeff Garzik wrote:
>>> Greg KH wrote:
>>>> On Mon, Nov 03, 2008 at 04:25:12AM -0800, Subbu Seetharaman wrote:
>>>>> If we could get more specific feedback about the areas that require
>>>>> cleanup, we can take care of them quickly.  Since the last posting, we 
>>>>> have brought up the driver in a PPC system
>>>>> and fixed some endianness issues.  As soon as I have some specific
>>>>> feedback, we can update the driver with these fixes as well.
>>>>>
>>>>> Please let me know as soon as the driver is in the staging area.
>>>> Does someone have a pointer to the driver, so that we can see what is
>>>> needed to be done?
>>> It was in my email :)  Repeating,
>>>
>>> The 'benet' branch of
>>> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
>>>
>>> It should be suitable for pulling directly into staging.
>> Hm, call me extreemly stupid, but I don't see anything in that branch
>> for this driver.
>> Here's what I did:
>>   git fetch 
>> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git benet 
>> master:jeff
>>   git checkout jeff
>> Even looking around at this tree with 'gitk --all' I don't see anything.
>> So what did I do wrong here?
>
> Well, the commit has been there long enough to mirror out, and show up on 
> the web interface:
>
> http://git.kernel.org/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=shortlog;h=benet
>
> therefore I am guessing there is some git user error here... but I could 
> not say what, since I am unfamiliar with your style of git invocation.
>
> I would recommend creating a new branch, or switching to an existing one, 
> and then pulling into it.  Pulling from a branch always works in my 
> experience, and that's what I've been doing since git was first written.
>
> URL=git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> git checkout -b tmp master
> git pull $URL benet

Ok, that worked just fine, sorry for the noise, I was trying to be
"nice" and not use 'git pull' and use 'git fetch' like I thought I was
supposed to be doing :)

I can take it from here...

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Jeff Garzik]

Greg KH wrote:
> On Mon, Nov 03, 2008 at 02:52:07PM -0500, Jeff Garzik wrote:
>> Greg KH wrote:
>>> On Mon, Nov 03, 2008 at 04:25:12AM -0800, Subbu Seetharaman wrote:
>>>> If we could get more specific feedback about the areas that require
>>>> cleanup, we can take care of them quickly.  
>>>> Since the last posting, we have brought up the driver in a PPC system
>>>> and fixed some endianness issues.  As soon as I have some specific
>>>> feedback, we can update the driver with these fixes as well.
>>>>
>>>> Please let me know as soon as the driver is in the staging area.
>>> Does someone have a pointer to the driver, so that we can see what is
>>> needed to be done?
>> It was in my email :)  Repeating,
>>
>> The 'benet' branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
>>
>> It should be suitable for pulling directly into staging.
> 
> Hm, call me extreemly stupid, but I don't see anything in that branch
> for this driver.
> 
> Here's what I did:
>   git fetch git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git benet master:jeff
>   git checkout jeff
> 
> Even looking around at this tree with 'gitk --all' I don't see anything.
> So what did I do wrong here?

Well, the commit has been there long enough to mirror out, and show up 
on the web interface:

http://git.kernel.org/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=shortlog;h=benet

therefore I am guessing there is some git user error here... but I could 
not say what, since I am unfamiliar with your style of git invocation.

I would recommend creating a new branch, or switching to an existing 
one, and then pulling into it.  Pulling from a branch always works in my 
experience, and that's what I've been doing since git was first written.

URL=git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
git checkout -b tmp master
git pull $URL benet

Regards,

	Jeff

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Mon, Nov 03, 2008 at 02:52:07PM -0500, Jeff Garzik wrote:
> Greg KH wrote:
>> On Mon, Nov 03, 2008 at 04:25:12AM -0800, Subbu Seetharaman wrote:
>>> If we could get more specific feedback about the areas that require
>>> cleanup, we can take care of them quickly.  
>>> Since the last posting, we have brought up the driver in a PPC system
>>> and fixed some endianness issues.  As soon as I have some specific
>>> feedback, we can update the driver with these fixes as well.
>>>
>>> Please let me know as soon as the driver is in the staging area.
>> Does someone have a pointer to the driver, so that we can see what is
>> needed to be done?
>
> It was in my email :)  Repeating,
>
> The 'benet' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
>
> It should be suitable for pulling directly into staging.

Hm, call me extreemly stupid, but I don't see anything in that branch
for this driver.

Here's what I did:
  git fetch git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git benet master:jeff
  git checkout jeff

Even looking around at this tree with 'gitk --all' I don't see anything.
So what did I do wrong here?

confused,

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Mon, Nov 03, 2008 at 02:52:07PM -0500, Jeff Garzik wrote:
> Greg KH wrote:
>> On Mon, Nov 03, 2008 at 04:25:12AM -0800, Subbu Seetharaman wrote:
>>> If we could get more specific feedback about the areas that require
>>> cleanup, we can take care of them quickly.  
>>> Since the last posting, we have brought up the driver in a PPC system
>>> and fixed some endianness issues.  As soon as I have some specific
>>> feedback, we can update the driver with these fixes as well.
>>>
>>> Please let me know as soon as the driver is in the staging area.
>> Does someone have a pointer to the driver, so that we can see what is
>> needed to be done?
>
> It was in my email :)  Repeating,
>
> The 'benet' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
>
> It should be suitable for pulling directly into staging.

Ah, sorry, missed that :)

I'll pull it in and post what I find.

thanks,

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Jeff Garzik]

Greg KH wrote:
> On Mon, Nov 03, 2008 at 04:25:12AM -0800, Subbu Seetharaman wrote:
>> If we could get more specific feedback about the areas that require
>> cleanup, we can take care of them quickly.  
>>
>> Since the last posting, we have brought up the driver in a PPC system
>> and fixed some endianness issues.  As soon as I have some specific
>> feedback, we can update the driver with these fixes as well.
>>
>> Please let me know as soon as the driver is in the staging area.
> 
> Does someone have a pointer to the driver, so that we can see what is
> needed to be done?

It was in my email :)  Repeating,

The 'benet' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git

It should be suitable for pulling directly into staging.

	Jeff

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Greg KH]

On Mon, Nov 03, 2008 at 04:25:12AM -0800, Subbu Seetharaman wrote:
> If we could get more specific feedback about the areas that require
> cleanup, we can take care of them quickly.  
> 
> Since the last posting, we have brought up the driver in a PPC system
> and fixed some endianness issues.  As soon as I have some specific
> feedback, we can update the driver with these fixes as well.
> 
> Please let me know as soon as the driver is in the staging area.

Does someone have a pointer to the driver, so that we can see what is
needed to be done?

thanks,

greg k-h

Re: [RESEND] benet: BladeEngine 10Gb NIC driver

[Subbu Seetharaman]

If we could get more specific feedback about the areas that require cleanup, we can take care of them quickly.  

Since the last posting, we have brought up the driver in a PPC system and fixed some endianness issues.  As soon as I have some specific feedback, we can update the driver with these fixes as well.

Please let me know as soon as the driver is in the staging area.

Thanks.

Subbu 

----- Original Message -----
From: Jeff Garzik [mailto:jeff@garzik.org]
To: Subbu Seetharaman [mailto:subbus@serverengines.com], Greg KH [mailto:greg@kroah.com]
Cc: netdev@vger.kernel.org, LKML [mailto:linux-kernel@vger.kernel.org]
Sent: Sun, 02 Nov 2008 05:15:15 -0800
Subject: Re: [RESEND] benet: BladeEngine 10Gb NIC driver


Subbu Seetharaman wrote:
> Jeff,
> 
> It is more than two months since the benet driver patch was made available as a single file as suggeted by you :
> 
> ftp://ftp.serverengines.com/0001.benet.patch
> 
> I have not seen this applied.  Is there any reason for not applying this  patch ?  Do you want a patch against the latest git tree ?

The overall consensus at this year's Linux Kernel Summit was that this 
driver still needs a lot of cleanup, so I'm gonna try an experiment and 
stick this in the staging tree (currently jgarzik/netdev-2.6.git#benet).

Greg, do I need to do anything beyond simply putting it into the 
directory?  Do I need to add some code to taint, perhaps?

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.