LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Denys Vlasenko <vda.linux@googlemail.com>
To: Helge Deller <deller@gmx.de>
Cc: Jiri Slaby <jirislaby@gmail.com>, Jiri Kosina <jkosina@suse.cz>,
Jeroen Roovers <jer@gentoo.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] USBHID: correct start/stop cycle
Date: Sun, 2 Nov 2008 20:24:31 +0100 [thread overview]
Message-ID: <200811022024.31528.vda.linux@googlemail.com> (raw)
In-Reply-To: <490DDA69.4000404@gmx.de>
On Sunday 02 November 2008 17:50, Helge Deller wrote:
> Jiri Slaby wrote:
> >>> btw. this is not expected to fix that, but if it does, the better ;).
> >> I tried the patch and sadly it didn't fixed the parisc bug.
> >
> > Could you bisect it?
>
> I fully bisected it, and the final "buggy" patch seems to have been
> Denys Vlasenko's patch: cb8f488c33539f096580e202f5438a809195008f
> (see
> http://github.com/jonsmirl/digispeaker/commit/cb8f488c33539f096580e202f5438a809195008f)
> Denys: Any reason you removed "!prev" in front of "expand_stack"?
Looks like I erroneously thought it can't be NULL,
or that expand_upwards() is ok with getting NULL vma parameter.
I looked again and neither is true.
Sorry, looks like I indeed broke this.
--
vda
next prev parent reply other threads:[~2008-11-02 19:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 22:41 Jiri Slaby
2008-11-01 23:02 ` Jiri Kosina
2008-11-01 23:07 ` Jiri Slaby
2008-11-02 10:43 ` Helge Deller
2008-11-02 10:55 ` Jiri Slaby
2008-11-02 16:50 ` Helge Deller
2008-11-02 19:24 ` Denys Vlasenko [this message]
2008-11-11 23:22 ` Jiri Kosina
2008-11-12 0:24 ` Denys Vlasenko
2008-11-12 0:34 ` Who broke cb8f488c33 patch? (was Re: [PATCH 1/1] USBHID: correct start/stop cycle) Jiri Kosina
2008-11-12 0:50 ` Andrew Morton
2008-11-12 9:23 ` Jiri Slaby
2008-11-13 15:32 ` Helge Deller
2008-11-13 16:22 ` Linus Torvalds
2008-11-11 22:52 ` [PATCH 1/1] USBHID: correct start/stop cycle Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811022024.31528.vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=deller@gmx.de \
--cc=jer@gentoo.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 1/1] USBHID: correct start/stop cycle' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).