Re: [PATCH] Identify which executable object the userspace address belongs to. Store thread group leader id, and use it to lookup the address in the process's map. We could have looked up the address on thread's map, but the thread might not exist by the time we are called. The process might not exist either, but if you are reading trace_pipe, that is unlikely.

LKML Archive on lore.kernel.org
help / color / mirror / Atom feed

From: Ingo Molnar <mingo@elte.hu>
To: "Török Edwin" <edwintorok@gmail.com>,
	"Andy Whitcroft" <apw@shadowen.org>
Cc: srostedt@redhat.com, a.p.zijlstra@chello.nl,
	sandmann@daimi.au.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Identify which executable object the userspace address belongs to. Store thread group leader id, and use it to lookup the address in the process's map. We could have looked up the address on thread's map, but the thread might not exist by the time we are called. The process might not exist either, but if you are reading trace_pipe, that is unlikely.
Date: Mon, 3 Nov 2008 09:21:48 +0100	[thread overview]
Message-ID: <20081103082148.GE28771@elte.hu> (raw)
In-Reply-To: <490EB361.9090007@gmail.com>


* Török Edwin <edwintorok@gmail.com> wrote:

> On 2008-11-03 09:47, Ingo Molnar wrote:
> > * Török Edwin <edwintorok@gmail.com> wrote:
> >
> >   
> >> +		struct task_struct *task;
> >> +		/* we do the lookup on the thread group leader,
> >> +		 * since individual threads might have already quit! */
> >>     
> >
> > please use the customary comment style:
> >
> >   /*
> >    * Comment .....
> >    * ...... goes here:
> >    */
> >
> >   
> 
> . Can checkpatch.pl warn me of situations like this?

Cc:-ed Andy - it would be a useful feature indeed. (since there's no 
hard CodingStyle rule for it, it could be a default-off helper)

	Ingo

next prev parent reply	other threads:[~2008-11-03  8:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-02 21:18 Add support for userspace stacktraces in tracing/iter_ctrl [v2] Török Edwin
2008-11-02 21:18 ` [PATCH] Add support for userspace stacktraces in tracing/iter_ctrl Török Edwin
2008-11-02 21:18   ` [PATCH] Identify which executable object the userspace address belongs to. Store thread group leader id, and use it to lookup the address in the process's map. We could have looked up the address on thread's map, but the thread might not exist by the time we are called. The process might not exist either, but if you are reading trace_pipe, that is unlikely Török Edwin
2008-11-02 21:25     ` Al Viro
2008-11-02 21:28       ` Török Edwin
2008-11-02 21:40         ` Al Viro
2008-11-03  7:32           ` Ingo Molnar
2008-11-04 18:26             ` Christoph Hellwig
2008-11-04 18:37               ` Török Edwin
2008-11-04 19:09                 ` Christoph Hellwig
2008-11-04 19:10                   ` Török Edwin
2008-11-06  9:55               ` Ingo Molnar
2008-11-06 12:26                 ` Christoph Hellwig
2008-11-06 15:32                   ` Ingo Molnar
2008-11-06 15:36                     ` Christoph Hellwig
2008-11-03  7:47     ` Ingo Molnar
2008-11-03  8:16       ` Török Edwin
2008-11-03  8:21         ` Ingo Molnar [this message]
2008-11-03  8:29         ` Ingo Molnar
2008-11-03 13:57           ` Török Edwin
2008-11-03 14:04             ` Ingo Molnar
2008-11-03 19:26           ` Mathieu Desnoyers
2008-11-03 19:56     ` Peter Zijlstra
2008-11-03 19:58       ` Arnaldo Carvalho de Melo
2008-11-03 20:01         ` Török Edwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081103082148.GE28771@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=apw@shadowen.org \
    --cc=edwintorok@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandmann@daimi.au.dk \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).