LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH-linux-next] ia64: fix build breakage in smp.h
@ 2008-10-31 18:56 Luck, Tony
2008-11-03 8:59 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Luck, Tony @ 2008-10-31 18:56 UTC (permalink / raw)
To: Ingo Molnar; +Cc: linux-kernel, Rusty Russell, Mike Travis
The commit:
"cpumask: switch over to cpu_online/possible/active/present_mask"
provides a define for cpu_online_map but did not delete the
declaration in arch/ia64/include/asm/smp.h resulting in this
build error:
CC arch/ia64/kernel/asm-offsets.s
In file included from include/linux/smp.h:30,
from include/linux/sched.h:68,
from arch/ia64/kernel/asm-offsets.c:9:
arch/ia64/include/asm/smp.h:60: error: expected ')' before '*' token
arch/ia64/include/asm/smp.h:60: error: expected ')' before 'cpu_online_mask'
Fix: just delete the declaration, it is no longer needed.
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Ingo: I think this belongs in the auto-cpus4096-next branch of the tip tree
diff --git a/arch/ia64/include/asm/smp.h b/arch/ia64/include/asm/smp.h
index 12d96e0..21c4023 100644
--- a/arch/ia64/include/asm/smp.h
+++ b/arch/ia64/include/asm/smp.h
@@ -57,7 +57,6 @@ extern struct smp_boot_data {
extern char no_int_routing __devinitdata;
-extern cpumask_t cpu_online_map;
extern cpumask_t cpu_core_map[NR_CPUS];
DECLARE_PER_CPU(cpumask_t, cpu_sibling_map);
extern int smp_num_siblings;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH-linux-next] ia64: fix build breakage in smp.h
2008-10-31 18:56 [PATCH-linux-next] ia64: fix build breakage in smp.h Luck, Tony
@ 2008-11-03 8:59 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-11-03 8:59 UTC (permalink / raw)
To: Luck, Tony; +Cc: linux-kernel, Rusty Russell, Mike Travis
* Luck, Tony <tony.luck@intel.com> wrote:
> The commit:
> "cpumask: switch over to cpu_online/possible/active/present_mask"
> provides a define for cpu_online_map but did not delete the
> declaration in arch/ia64/include/asm/smp.h resulting in this
> build error:
>
> CC arch/ia64/kernel/asm-offsets.s
> In file included from include/linux/smp.h:30,
> from include/linux/sched.h:68,
> from arch/ia64/kernel/asm-offsets.c:9:
> arch/ia64/include/asm/smp.h:60: error: expected ')' before '*' token
> arch/ia64/include/asm/smp.h:60: error: expected ')' before 'cpu_online_mask'
>
> Fix: just delete the declaration, it is no longer needed.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
applied to tip/cpus4096, thanks Tony!
> Ingo: I think this belongs in the auto-cpus4096-next branch of the
> tip tree
yes, thanks. I've pushed out a new version of auto-cpus4096-next.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-03 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-31 18:56 [PATCH-linux-next] ia64: fix build breakage in smp.h Luck, Tony
2008-11-03 8:59 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).