LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch] fix 64-vbit prefetchable memory resource BARs
@ 2008-10-13  0:49 Peter Chubb
  2008-10-13  1:34 ` Matthew Wilcox
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Peter Chubb @ 2008-10-13  0:49 UTC (permalink / raw)
  To: matthew, jbarnes, linux-kernel, linux-pci


Since patch 6ac665c63dcac8fcec534a1d224ecbb8b867ad59
my infiniband controller hasn't worked.  This is because it has
64-bit prefetchable memory, which was mistakenly being  taken to be
32-bit memory.  The resource flags in this case are
PCI_BASE_ADDRESS_MEM_TYPE_64|PCI_BASE_ADDRESS_MEM_PREFETCH.

This patch checks only for the PCI_BASE_ADDRESS_MEM_TYPE_64 bit; thus
whether the region is prefetchable or not is ignored.  This fixes my
Infiniband.


Signed-off-by: Peter Chubb <peterc@gelato.unsw.edu.au>

Index: linux-2.6-git/drivers/pci/probe.c
===================================================================
--- linux-2.6-git.orig/drivers/pci/probe.c	2008-10-13 10:49:46.012798465 +1100
+++ linux-2.6-git/drivers/pci/probe.c	2008-10-13 11:35:43.016329442 +1100
@@ -219,7 +219,7 @@
 
 	res->flags = bar & ~PCI_BASE_ADDRESS_MEM_MASK;
 
-	if (res->flags == PCI_BASE_ADDRESS_MEM_TYPE_64)
+	if (res->flags & PCI_BASE_ADDRESS_MEM_TYPE_64)
 		return pci_bar_mem64;
 	return pci_bar_mem32;
 }


--
Dr Peter Chubb  http://www.gelato.unsw.edu.au  peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au           ERTOS within National ICT Australia

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-11-03 20:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-13  0:49 [patch] fix 64-vbit prefetchable memory resource BARs Peter Chubb
2008-10-13  1:34 ` Matthew Wilcox
2008-10-15 10:05 ` Jesse Barnes
2008-11-03 20:42 ` Bjorn Helgaas
2008-11-03 20:47   ` [stable] " Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).