LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 3/3] ftrace: function tracer with irqs disabled
Date: Tue, 4 Nov 2008 17:43:58 +0100	[thread overview]
Message-ID: <20081104164358.GB27339@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0811040919060.4140@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> > > > tracing type       times            entries recorded
> > > > ------------      --------          ----------------
> > > > irq disabled      43.393            166433066
> > > >                   43.282            166172618
> > > >                   43.298            166256704
> > > > 
> > > > preempt disabled  38.969            159871710
> > > >                   38.943            159972935
> > > >                   39.325            161056510

> When we used the preempt disabled version, we lost 5 million traces, 
> as suppose to the irq disabled which was only 1,150 traces lost.
> 
> Considering that we had 166,256,704 traces total, that 5 million is 
> only 4% lost of traces. Still quite a lot. But again, this is an 
> extreme, because we are tracing hackbench.

there's about 10% difference between the two hackbench results - so 
the lack of 5% of the traces could make up for about half of that 
overhead.

anyway, that still leaves the other 5% as the _true_ overhead of IRQ 
disable.

is there some other workload that does not lose this many trace 
entries, making it easier to compare irqs-off against preempt-off?

	Ingo

      reply	other threads:[~2008-11-04 16:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  4:15 [PATCH 0/3] ftrace: code consolidation Steven Rostedt
2008-11-04  4:15 ` [PATCH 1/3] ftrace: ftrace_preempt_disable Steven Rostedt
2008-11-04  9:10   ` Ingo Molnar
2008-11-04 21:48     ` [PATCH] ftrace: ftrace_preempt_disable comment fix Steven Rostedt
2008-11-04 21:52       ` [PATCH v2] " Steven Rostedt
2008-11-04 22:05         ` [PATCH v3] " Steven Rostedt
2008-11-04  4:15 ` [PATCH 2/3] ftrace: insert in the ftrace_preempt_disable functions Steven Rostedt
2008-11-04  4:15 ` [PATCH 3/3] ftrace: function tracer with irqs disabled Steven Rostedt
2008-11-04  8:07   ` Ingo Molnar
2008-11-04  8:17     ` Zhang, Yanmin
2008-11-04  9:04     ` Ingo Molnar
2008-11-04 14:44       ` Steven Rostedt
2008-11-04 16:43         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081104164358.GB27339@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 3/3] ftrace: function tracer with irqs disabled' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).