LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Suresh Siddha <email@example.com>
To: Ingo Molnar <firstname.lastname@example.org>
Cc: Jeremy Fitzhardinge <email@example.com>,
"Siddha, Suresh B" <firstname.lastname@example.org>,
"Mallick, Asit K" <email@example.com>,
Subject: Re: [patch] generic-ipi: fix the smp_mb() placement
Date: Tue, 4 Nov 2008 14:25:10 -0800 [thread overview]
Message-ID: <20081104222509.GA12358@linux-os.sc.intel.com> (raw)
On Tue, Nov 04, 2008 at 02:19:56AM -0700, Ingo Molnar wrote:
> * Jeremy Fitzhardinge <firstname.lastname@example.org> wrote:
> > Ingo Molnar wrote:
> >> ok - so that makes it a v2.6.28 item i guess.
> > The case Suresh is talking about was a fix to Xen itself, rather
> > than on the kernel side, so it doesn't need to be a .28 issue on
> > Xen's account.
> ok - but still the portion of the fix that strengthens barriers looks
> obvious to have and there's little downside that i can see.
> Suresh, you might want to split the patch(es) in two: get the barrier
> strengthening changes into v2.6.28 (to fix the x2apic bug), while the
> aspects that _weaken_ barriers can wait for v2.6.29.
> With that it would be a 100% safe change for v2.6.28-rc4.
Ok. I just posted three patches (including the x86 specific change).
[patch 1/3] generic-ipi: add smp_mb() before sending the IPI
[patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR
[patch 3/3] generic-ipi: fix the smp_mb() usage
First two patches are safe to go into v2.6.28. Third patch can wait for v2.6.29.
next prev parent reply other threads:[~2008-11-04 22:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 22:42 Suresh Siddha
2008-10-30 7:20 ` Jens Axboe
2008-10-30 16:30 ` Suresh Siddha
2008-10-30 17:25 ` Jens Axboe
2008-10-30 18:53 ` Ingo Molnar
2008-10-30 20:23 ` Suresh Siddha
2008-10-31 5:10 ` Jeremy Fitzhardinge
2008-10-31 9:39 ` Ingo Molnar
2008-10-31 11:12 ` Jeremy Fitzhardinge
2008-10-31 16:53 ` Suresh Siddha
2008-10-31 20:30 ` Jeremy Fitzhardinge
2008-11-03 10:17 ` Ingo Molnar
2008-11-03 23:48 ` Jeremy Fitzhardinge
2008-11-04 9:19 ` Ingo Molnar
2008-11-04 22:25 ` Suresh Siddha [this message]
2008-11-05 9:20 ` Jens Axboe
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [patch] generic-ipi: fix the smp_mb() placement' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).