LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Jörn Engel" <joern@logfs.org>
Cc: Matthieu CASTET <matthieu.castet@parrot.com>,
	Linux Arm Mailing List  <linux-arm-kernel@lists.arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: arm checkstack
Date: Wed, 5 Nov 2008 17:13:14 +0100	[thread overview]
Message-ID: <200811051713.15352.arnd@arndb.de> (raw)
In-Reply-To: <20081104173524.GB16036@logfs.org>

On Tuesday 04 November 2008, Jörn Engel wrote:
> On Tue, 4 November 2008 17:06:28 +0100, Matthieu CASTET wrote:
> > 
> > I wonder why the arm version of checkstack only catch stack size >= 300
> > and < 10000 [1].
> > Why doesn't it use ".*sub.*sp, sp, #([0-9]{1,8})" to catch all stack usage ?
> 
> Looks like a bug.  And it further looks like Holger just copied what
> everyone else did at the time.  And the one who started this strange
> pattern was: Arnd.
> 
> Arnd, did you have a good reason for choosing the pattern?
> 

don't really remember what I thought back then. Probably I tried to filter
out any function lower than 300 bytes as early as possible and did not think
of the >= 10000 case.

	Arnd <><

      parent reply	other threads:[~2008-11-05 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 16:06 Matthieu CASTET
2008-11-04 17:35 ` Jörn Engel
2008-11-04 19:58   ` [Patch][Checkstack] Do not hide small stackframes Jörn Engel
2008-11-05 16:13   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811051713.15352.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=joern@logfs.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthieu.castet@parrot.com \
    --subject='Re: arm checkstack' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).