LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
	jeremy.fitzhardinge@citrix.com, nickpiggin@yahoo.com.au,
	torvalds@linux-foundation.org, paulmck@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com
Subject: Re: [patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR
Date: Thu, 6 Nov 2008 09:43:31 +0100	[thread overview]
Message-ID: <20081106084331.GY21867@kernel.dk> (raw)
In-Reply-To: <20081106084211.GA4890@elte.hu>

On Thu, Nov 06 2008, Ingo Molnar wrote:
> 
> * Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> 
> > On x86, x2apic mode accesses for sending IPI's don't have 
> > serializing semantics. If the IPI receiver refers(in lock-free 
> > fashion) to some memory setup by the sender, the need for smp_mb() 
> > before sending the IPI becomes critical in x2apic mode.
> > 
> > Add the smp_mb() in native_flush_tlb_others() before sending the 
> > IPI.
> > 
> > Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> 
> applied to tip/x86/urgent, thanks Suresh!
> 
> Jens, you'll send 1/3 and 3/3 to Linus, right?

Yes, it's in for-linus and I'll send the pull request today.

-- 
Jens Axboe


  reply	other threads:[~2008-11-06  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 21:53 [patch 1/3] generic-ipi: add smp_mb() before sending the IPI Suresh Siddha
2008-11-04 21:53 ` [patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR Suresh Siddha
2008-11-06  8:42   ` Ingo Molnar
2008-11-06  8:43     ` Jens Axboe [this message]
2008-11-04 21:53 ` [patch 3/3] generic-ipi: fix the smp_mb() usage Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081106084331.GY21867@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=venkatesh.pallipadi@intel.com \
    --subject='Re: [patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).