LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3
Date: Thu, 6 Nov 2008 12:21:07 -0200 [thread overview]
Message-ID: <20081106142107.GC23278@khazad-dum.debian.net> (raw)
In-Reply-To: <20081106082314.GA18430@x61>
On Thu, 06 Nov 2008, Tino Keitel wrote:
> The whole fan level stuff looks a bit complicated to me. Especially the
It is. The sysfs hwmon interface does not map 1:1 with the three possible
thinkpad fan control interfaces. fan_control_desired_level is used for that
interface mainly, since I have to remember the last state used that was in
the set of 0-7, ignoring AUTO (which is a separate pwm control mode for
hwmon) and full-speed (which is a separate pwm control mode for hwmon).
It is hijacked by fan_suspend/fan_resume to store state between
sleep/resume, because that was convenient. Too bad I failed to notice it
would not work properly for that.
> The attached patch tries to simplify this a bit. It sets
NAK, it would break a lot of stuff. See my previous reply on this thread
for *some* of the stuff it would break.
I will have a proper patch out probably within 24h but most certainly before
next Monday.
Meanwhile, I suggest you just remove the calls to fan_suspend and fan_resume
as a workaround.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-11-06 14:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 7:33 Tino Keitel
2008-11-05 7:47 ` [ibm-acpi-devel] " Tino Keitel
2008-11-05 12:26 ` Henrique de Moraes Holschuh
2008-11-05 13:02 ` Tino Keitel
2008-11-05 13:08 ` Tino Keitel
2008-11-05 16:24 ` Henrique de Moraes Holschuh
2008-11-06 0:35 ` Tino Keitel
2008-11-06 8:23 ` Tino Keitel
2008-11-06 14:21 ` Henrique de Moraes Holschuh [this message]
2008-11-08 22:45 ` Rafael J. Wysocki
2008-11-09 11:30 ` Henrique de Moraes Holschuh
2008-11-09 12:54 ` [GIT PATCH] thinkpad-acpi regression fix for 2.6.28-rc Henrique de Moraes Holschuh
2008-11-09 13:22 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2008-11-09 12:54 ` [PATCH] ACPI: thinkpad-acpi: fix fan sleep/resume path Henrique de Moraes Holschuh
2008-11-12 5:02 ` Len Brown
2008-11-17 2:14 ` Henrique de Moraes Holschuh
2008-11-17 14:26 ` [ibm-acpi-devel] " Tino Keitel
2008-11-13 7:26 ` [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3 Pavel Machek
2008-11-06 14:11 ` Henrique de Moraes Holschuh
2008-11-06 15:22 ` Tino Keitel
2008-11-06 15:31 ` Henrique de Moraes Holschuh
2008-11-06 15:32 ` Tino Keitel
2008-11-06 21:15 ` Henrique de Moraes Holschuh
2008-11-05 13:45 ` Tino Keitel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081106142107.GC23278@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).