[PATCH] x86: align DirectMap in /proc/meminfo

[PATCH] x86: align DirectMap in /proc/meminfo

[Hugh Dickins]

When the split-LRU patches added Inactive(anon) and Inactive(file) lines
to /proc/meminfo, all counts were moved two columns rightwards to fit in.
Now move x86's DirectMap lines two columns rightwards to line up.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
Being a timid soul, I do wonder if realigning two columns rightwards was
a reckless breakage of the kernel-userspace API!  but assume that was
thrashed out at the time, and I've heard of no complaints.

 arch/x86/mm/pageattr.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- 2.6.28-rc3/arch/x86/mm/pageattr.c	2008-10-24 09:27:48.000000000 +0100
+++ linux/arch/x86/mm/pageattr.c	2008-11-03 15:00:17.000000000 +0000
@@ -67,18 +67,18 @@ static void split_page_count(int level)
 
 void arch_report_meminfo(struct seq_file *m)
 {
-	seq_printf(m, "DirectMap4k:  %8lu kB\n",
+	seq_printf(m, "DirectMap4k:    %8lu kB\n",
 			direct_pages_count[PG_LEVEL_4K] << 2);
 #if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
-	seq_printf(m, "DirectMap2M:  %8lu kB\n",
+	seq_printf(m, "DirectMap2M:    %8lu kB\n",
 			direct_pages_count[PG_LEVEL_2M] << 11);
 #else
-	seq_printf(m, "DirectMap4M:  %8lu kB\n",
+	seq_printf(m, "DirectMap4M:    %8lu kB\n",
 			direct_pages_count[PG_LEVEL_2M] << 12);
 #endif
 #ifdef CONFIG_X86_64
 	if (direct_gbpages)
-		seq_printf(m, "DirectMap1G:  %8lu kB\n",
+		seq_printf(m, "DirectMap1G:    %8lu kB\n",
 			direct_pages_count[PG_LEVEL_1G] << 20);
 #endif
 }

Re: [PATCH] x86: align DirectMap in /proc/meminfo

[Ingo Molnar]

* Hugh Dickins <hugh@veritas.com> wrote:

> When the split-LRU patches added Inactive(anon) and Inactive(file) lines
> to /proc/meminfo, all counts were moved two columns rightwards to fit in.
> Now move x86's DirectMap lines two columns rightwards to line up.
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Being a timid soul, I do wonder if realigning two columns rightwards was
> a reckless breakage of the kernel-userspace API!  but assume that was
> thrashed out at the time, and I've heard of no complaints.

good question - but i have not heard complaints either.

>  arch/x86/mm/pageattr.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

applied to tip/x86/urgent, thanks Hugh!

	Ingo