LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	"Christopher S. Aker" <caker@theshore.net>,
	xen devel <xen-devel@lists.xensource.com>,
	Jan Beulich <jbeulich@novell.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU
Date: Thu, 6 Nov 2008 22:22:56 +0100	[thread overview]
Message-ID: <20081106212256.GC24579@elte.hu> (raw)
In-Reply-To: <49135F84.2060302@goop.org>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
>> a "cleanup" impact line is only added if the change is not intended to  
>> have any side-effects whatsoever.
>>
>> We can drop it but it would be really nice to figure out what's going  
>> on. In a very quick late-night look i cannot see anything particularly  
>> weird about it, but based on the type of changes it does there are  
>> three leading candidates: lost high 32 bits, zero extend problem, or  
>> incorrect types.
>
> Yeah, I couldn't see anything either.  It's a reasonable cleanup (I 
> never did understand that struct page * cast), but its always nicer 
> when cleanups don't break working code ;).

Would be nice to have a look at the vmlinux delta with the patch 
reverted, on the .config that breaks. By all means the object code 
should be the same.

	Ingo

  reply	other threads:[~2008-11-06 21:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <48F3BC99.5040409@theshore.net>
     [not found] ` <490F5F50.7020704@theshore.net>
     [not found]   ` <4910AD00.7040605@theshore.net>
     [not found]     ` <4911BC52.7040905@theshore.net>
     [not found]       ` <1225994697.12607.837.camel@zakaz.uk.xensource.com>
2008-11-06 19:15         ` [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU Jeremy Fitzhardinge
2008-11-06 21:16           ` Ingo Molnar
2008-11-06 21:20             ` Jeremy Fitzhardinge
2008-11-06 21:22               ` Ingo Molnar [this message]
2008-11-06 21:28             ` Jeremy Fitzhardinge
2008-11-06 21:33               ` Ingo Molnar
2008-11-06 21:48                 ` Jeremy Fitzhardinge
2008-11-06 22:20                   ` Ingo Molnar
2008-11-06 22:29                     ` Jeremy Fitzhardinge
2008-11-07  9:53                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081106212256.GC24579@elte.hu \
    --to=mingo@elte.hu \
    --cc=Ian.Campbell@citrix.com \
    --cc=caker@theshore.net \
    --cc=jbeulich@novell.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).