LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Zhao Yakui <yakui.zhao@intel.com>, Len Brown <lenb@kernel.org>,
Andrey Borzenkov <arvidjaar@mail.ru>, Ingo Molnar <mingo@elte.hu>,
Eduardo Habkost <ehabkost@redhat.com>,
Avi Kivity <avi@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@osdl.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI"
Date: Fri, 7 Nov 2008 01:43:42 +0000 [thread overview]
Message-ID: <20081107014342.GA9841@srcf.ucam.org> (raw)
In-Reply-To: <49139A43.4000203@shaw.ca>
On Thu, Nov 06, 2008 at 07:30:43PM -0600, Robert Hancock wrote:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8fd145917fb62368a9b80db59562c20576238f5a
>
> This patch ignores the RESET_REG_SUP flag and just tries using the reset
> register anyway if it thinks it's valid. So we may attempt ACPI reset on
> machines which don't indicate it's supported.
Yeah, that sounds very wrong.
> The patch description mentioned that some machines didn't reboot after
> S3 suspend without this patch. However, we recently had this patch merged:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a68823ee5285e65b51ceb96f8b13a5b4f99a6888
>
> Is it possible that the problem fixed there is the true cause of this
> reboot after S3 problem?
Oh, yeah, could be. Given the From:, I should really have thought of
that :)
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-11-07 1:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.UVpnVba3yRAWG3rGZ0sk20JE9hs@ifi.uio.no>
[not found] ` <fa.FPBNKx3BSvZHPZ+eXD4Tb+fuRYk@ifi.uio.no>
[not found] ` <fa.PvVEuEo+f/t4sLmcGyN2Tsl8zYg@ifi.uio.no>
[not found] ` <fa.zzFdOXisTZzBaE1+ueGIYmt+Z5c@ifi.uio.no>
[not found] ` <fa.vQ6HVRcPFFr1zpcXFFOjEPtDdNk@ifi.uio.no>
[not found] ` <fa.ckUqcrtVKbxAkjNggIdajBTHr9Q@ifi.uio.no>
2008-11-07 1:30 ` Robert Hancock
2008-11-07 1:43 ` Matthew Garrett [this message]
2008-11-07 1:53 ` Len Brown
2008-11-08 22:32 ` Rafael J. Wysocki
2008-11-05 19:56 [PATCH 00/15] x86: disable virt on kdump and emergency_restart (v2) Eduardo Habkost
2008-11-05 19:56 ` [PATCH 15/15] Revert "x86: default to reboot via ACPI" Eduardo Habkost
2008-11-06 7:14 ` Ingo Molnar
2008-11-06 12:40 ` Eduardo Habkost
2008-11-06 14:30 ` Ingo Molnar
2008-11-06 15:06 ` Ingo Molnar
2008-11-06 15:41 ` Eric W. Biederman
2008-11-06 15:52 ` Avi Kivity
2008-11-06 15:53 ` Andrey Borzenkov
2008-11-06 19:50 ` Len Brown
2008-11-06 21:50 ` Matthew Garrett
2008-11-06 22:17 ` Len Brown
2008-11-06 23:24 ` Matthew Garrett
2008-11-07 1:01 ` Zhao Yakui
2008-11-07 0:59 ` Matthew Garrett
2008-11-09 10:11 ` Avi Kivity
2008-11-09 10:24 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107014342.GA9841@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=akpm@osdl.org \
--cc=arvidjaar@mail.ru \
--cc=avi@redhat.com \
--cc=ebiederm@xmission.com \
--cc=ehabkost@redhat.com \
--cc=hancockr@shaw.ca \
--cc=kexec@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=yakui.zhao@intel.com \
--subject='Re: [PATCH 15/15] Revert "x86: default to reboot via ACPI"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).