LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: Michael Trimarchi <trimarchimichael@yahoo.it>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Check if the Hangcheck-timer TSC source is stable
Date: Fri, 7 Nov 2008 01:23:14 -0800 [thread overview]
Message-ID: <20081107092314.GI15220@mail.oracle.com> (raw)
In-Reply-To: <491371A8.3090603@yahoo.it>
On Thu, Nov 06, 2008 at 11:37:28PM +0100, Michael Trimarchi wrote:
> Check if the TSC source is stable otherwise fail registration.
Good idea.
> @@ -151,8 +155,10 @@ static void hangcheck_fire(unsigned long data)
>
> if (cur_tsc > hangcheck_tsc)
> tsc_diff = cur_tsc - hangcheck_tsc;
> - else
> - tsc_diff = (cur_tsc + (~0ULL - hangcheck_tsc)); /* or something */
> + else {
> + /* or samenthing */
> + tsc_diff = (cur_tsc + (~0ULL - hangcheck_tsc));
> + }
This hunk isn't any good. The comment spelling is messed up,
and really you can just remove the "or something".
Joel
--
"There is no sincerer love than the love of food."
- George Bernard Shaw
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-11-07 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 22:37 [RFC PATCH] Check if the Hangcheck-timer TSC source is stable Michael Trimarchi
2008-11-07 9:23 ` Joel Becker [this message]
2008-11-10 8:21 ` [RFC PATCH V2] " michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107092314.GI15220@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trimarchimichael@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).