LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Eric Dumazet <dada1@cosmosbay.com>, Ingo Molnar <mingo@elte.hu>,
	Pekka J Enberg <penberg@cs.helsinki.fi>,
	linux kernel <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: linux-2.6.28-rc2 regression : oprofile doesnt work anymore ?
Date: Fri, 7 Nov 2008 17:26:53 +0100	[thread overview]
Message-ID: <20081107162651.GP9785@erda.amd.com> (raw)
In-Reply-To: <20081107130249.GN29626@one.firstfloor.org>

On 07.11.08 14:02:49, Andi Kleen wrote:
> 
> Can you please test this patch and see if it solves the problem?
> 
> Thanks,
> -Andi
> 
> ---
> 
> oprofile: Fix p6 counter overflow check
> 
> Fix the counter overflow check for CPUs with counter width > 32
> 
> I had a similar change in a different patch that I didn't submit
> and I didn't notice the problem earlier because it was always
> tested together.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Andi,

your patch fixes the initial bug that stops sampling immediately after
starting. The issue Eric mentions seems to be a different problem. I
am also not able to reproduce this. Your patch on top of rc3 continues
sampling at least for several minutes.

I will apply your fix.

Thanks Andi,

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com


  parent reply	other threads:[~2008-11-07 16:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 18:01 Eric Dumazet
2008-10-31 14:21 ` Pekka Enberg
2008-11-04 18:18   ` Robert Richter
2008-11-04 19:19     ` Pekka J Enberg
2008-11-04 22:32       ` Eric Dumazet
2008-11-05  6:09         ` Eric Dumazet
2008-11-06 15:00           ` Eric Dumazet
2008-11-07 13:02             ` Andi Kleen
2008-11-07 15:13               ` Eric Dumazet
2008-11-07 16:05                 ` Andi Kleen
2008-11-07 16:12                   ` Eric Dumazet
2008-11-07 16:47                     ` Andi Kleen
2008-11-07 16:51                       ` Eric Dumazet
2008-11-07 16:26               ` Robert Richter [this message]
2008-11-04 22:58       ` Andi Kleen
2008-11-04 20:09     ` Andi Kleen
2008-10-31 16:08 ` Jesper Dangaard Brouer
2008-11-01  2:29 ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081107162651.GP9785@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --subject='Re: linux-2.6.28-rc2 regression : oprofile doesnt work anymore ?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).