LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Vegard Nossum <vegard.nossum@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Koyama, Yoshiya" <Yoshiya.Koyama@hp.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alexey Dobriyan <adobriyan@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
LKML <linux-kernel@vger.kernel.org>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: v2.6.28-rc1: readlink /proc/*/exe returns uninitialized data to userspace
Date: Fri, 7 Nov 2008 11:05:44 -0800 [thread overview]
Message-ID: <20081107190544.GA1551@kroah.com> (raw)
In-Reply-To: <20081106100410.GN4890@elte.hu>
On Thu, Nov 06, 2008 at 11:04:10AM +0100, Ingo Molnar wrote:
>
> * Al Viro <viro@ZenIV.linux.org.uk> wrote:
>
> > On Tue, Nov 04, 2008 at 10:39:19AM +0100, Vegard Nossum wrote:
> > > On Sun, Oct 26, 2008 at 10:08 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> > > # uname -a
> > > Linux localhost.localdomain 2.6.25.11-97.fc9.i686 #1 SMP Mon Jul 21
> > > 01:31:09 EDT 2008 i686 i686 i386 GNU/Linux
> > > # prelink -mRf /sbin/udevd
> > > # ./a.out /proc/564/exe
> > > warning: /proc/564/exe: got return value 38, expected 11
> > > 2f7362696e2f7564657664005f47387942426e5952446e566f306868202864656c6574656429
> > > /sbin/udevd _G8yBBnYRDnVo0hh (deleted)
> > >
> > > Yoshiya Koyama reports that the problem exists on RHEL 2.6.9-42.ELsmp too.
> > >
> > > I don't think it's exactly the same problem as originally reported,
> > > because I definitely wasn't using prelinking (the prelink binary
> > > wasn't even installed on the machine until today). But finding the
> > > root cause of this may solve both problems.
> >
> > switch_names() buggered in case of short names on both sides. That should
> > help:
> >
> > >From 2acda856910b774717e0290bbf948c7dee0f2e1a Mon Sep 17 00:00:00 2001
> > From: Al Viro <viro@zeniv.linux.org.uk>
> > Date: Mon, 3 Nov 2008 15:03:50 -0500
> > Subject: [PATCH] fix switch_names() breakage in short-to-short case
> >
> > We want ->name.len to match the resulting name on *both*
> > source and target
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> please credit kmemcheck in the commit message and use an appropriate
> Reported-by line as well. Thanks,
Did this fix ever get merged into Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2008-11-07 20:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 17:14 Vegard Nossum
2008-10-25 20:41 ` Rafael J. Wysocki
2008-10-25 22:28 ` Eric W. Biederman
2008-10-26 21:08 ` Vegard Nossum
2008-11-04 9:39 ` Vegard Nossum
2008-11-04 10:00 ` Alexey Dobriyan
2008-11-04 10:07 ` Alexey Dobriyan
2008-11-04 10:34 ` Alexey Dobriyan
2008-11-04 10:54 ` Eric W. Biederman
2008-11-04 15:48 ` Al Viro
2008-11-04 15:12 ` Al Viro
2008-11-06 10:04 ` Ingo Molnar
2008-11-07 19:05 ` Greg KH [this message]
2008-11-07 23:12 ` Alexey Dobriyan
2008-11-11 22:14 ` Andrew Morton
2008-11-11 22:53 ` Vegard Nossum
2008-12-03 17:18 ` Greg KH
2008-12-03 20:20 ` Andrew Morton
2008-12-07 5:44 ` Greg KH
2008-12-07 7:04 ` Al Viro
2008-10-26 0:23 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107190544.GA1551@kroah.com \
--to=greg@kroah.com \
--cc=Yoshiya.Koyama@hp.com \
--cc=adobriyan@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=vegard.nossum@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
--subject='Re: v2.6.28-rc1: readlink /proc/*/exe returns uninitialized data to userspace' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).