LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3
Date: Sun, 9 Nov 2008 09:30:11 -0200	[thread overview]
Message-ID: <20081109113011.GB8329@khazad-dum.debian.net> (raw)
In-Reply-To: <200811082345.37061.rjw@sisk.pl>

On Sat, 08 Nov 2008, Rafael J. Wysocki wrote:
> > Meanwhile, I suggest you just remove the calls to fan_suspend and fan_resume
> > as a workaround.
> 
> Speaking of which, last time I looked at fan_suspend and fan_resume, they
> were hopelessly broken (I admit that was quite some time ago, though).

And they still were. I have the patch fixing it, and it reworked that path
entirely.  Will send it soon.

> IMO, fan_suspend() is not necessary at all and the only thing fan_resume()
> could do is to make the kernel's data structures reflect the actual state of
> the fan.

There are NO kernel data structures to reflect the actual state of the fan.
The fan BELONGS to the EC in the thinkpad.  We don't store any crap about it
in the driver, except to -track- one quirk.  We query the EC for all the
required data (which happens to be a single byte) every time we need the
info.  If the user asks us to do something, we send that to the EC and then
promptly forget about it.

So, I don't have to restore anything for things to just work.  The "feature"
was added because people who set the fan to something different than AUTO
wanted it to retain the state they set across sleep, which the box won't do
by itself (the DSDT resets the fan on the WAK path).

OTOH, if I want to restore anything across sleep/resume, I have to store the
state on sleep.

But there is no way I am slowing down the fan on resume: it could be in
emergency mode due to thermal conditions.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2008-11-09 11:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05  7:33 Tino Keitel
2008-11-05  7:47 ` [ibm-acpi-devel] " Tino Keitel
2008-11-05 12:26   ` Henrique de Moraes Holschuh
2008-11-05 13:02     ` Tino Keitel
2008-11-05 13:08     ` Tino Keitel
2008-11-05 16:24       ` Henrique de Moraes Holschuh
2008-11-06  0:35         ` Tino Keitel
2008-11-06  8:23           ` Tino Keitel
2008-11-06 14:21             ` Henrique de Moraes Holschuh
2008-11-08 22:45               ` Rafael J. Wysocki
2008-11-09 11:30                 ` Henrique de Moraes Holschuh [this message]
2008-11-09 12:54                   ` [GIT PATCH] thinkpad-acpi regression fix for 2.6.28-rc Henrique de Moraes Holschuh
2008-11-09 13:22                     ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2008-11-09 12:54                   ` [PATCH] ACPI: thinkpad-acpi: fix fan sleep/resume path Henrique de Moraes Holschuh
2008-11-12  5:02                     ` Len Brown
2008-11-17  2:14                     ` Henrique de Moraes Holschuh
2008-11-17 14:26                       ` [ibm-acpi-devel] " Tino Keitel
2008-11-13  7:26                   ` [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3 Pavel Machek
2008-11-06 14:11           ` Henrique de Moraes Holschuh
2008-11-06 15:22             ` Tino Keitel
2008-11-06 15:31               ` Henrique de Moraes Holschuh
2008-11-06 15:32             ` Tino Keitel
2008-11-06 21:15               ` Henrique de Moraes Holschuh
2008-11-05 13:45     ` Tino Keitel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081109113011.GB8329@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --subject='Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).