LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 2/2] ring-buffer: no preempt for sched_clock
Date: Wed, 12 Nov 2008 11:24:03 +0100	[thread overview]
Message-ID: <20081112102403.GB24482@elte.hu> (raw)
In-Reply-To: <20081112050219.202854960@goodmis.org>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> Impact: disable preemption no calling sched_clock
> 
> The ring_buffer_time_stamp still uses sched_clock as its counter.
> But it is a bug to call it with preemption enabled. This requirement
> should not be pushed to the ring_buffer_time_stamp callers, so
> the ring_buffer_time_stamp needs to disable preemption when calling
> sched_clock.
> 
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> ---
>  kernel/trace/ring_buffer.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)

applied to tip/tracing/urgent, thanks Steve!

	Ingo

      reply	other threads:[~2008-11-12 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12  5:01 [PATCH 0/2] ring-buffer updates for tip Steven Rostedt
2008-11-12  5:01 ` [PATCH 1/2] ring-buffer: fix deadlock from reader_lock in read_start Steven Rostedt
2008-11-12 10:25   ` Ingo Molnar
2008-11-12  5:01 ` [PATCH 2/2] ring-buffer: no preempt for sched_clock Steven Rostedt
2008-11-12 10:24   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112102403.GB24482@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --subject='Re: [PATCH 2/2] ring-buffer: no preempt for sched_clock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).