LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 0/2] unlikely profiler and tracer
Date: Wed, 12 Nov 2008 19:21:31 +0100	[thread overview]
Message-ID: <20081112182131.GB4562@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0811121035180.2529@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> 
> On Wed, 12 Nov 2008, Ingo Molnar wrote:
> > two more small details i noticed:
> > 
> >  - does it do proper self-test? It doesnt seem so at first sight.
> 
> Hmm, no. The problem is that it is a switch to be added to other 
> tracers. There's not a branch profiling tracer itself. I could add 
> one that just does that, and that could do the self test.

i know that it's an iter_ctrl detail, but nevertheless the branch 
tracer (which is how people will be using this) should have some 
self-test.

it might also make sense to just have a standalone 'branch' tracer 
plugin as well. We have all the callbacks in place already, and people 
might be interested in just that info - not in some other tracing 
output.

	Ingo

      reply	other threads:[~2008-11-12 18:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12  5:14 Steven Rostedt
2008-11-12  5:14 ` [PATCH 1/2] trace: profile likely and unlikely annotations Steven Rostedt
2008-11-12  5:14 ` [PATCH 2/2] ftrace: unlikely annotation tracer Steven Rostedt
2008-11-12 11:25   ` [PATCH] tracing: branch tracer, tweak output Ingo Molnar
2008-11-12 12:13     ` Ingo Molnar
2008-11-12 12:27     ` [PATCH] tracing: branch tracer, fix vdso crash Ingo Molnar
2008-11-12 13:04     ` [PATCH] tracing: branch tracer, tweak output Steven Rostedt
2008-11-12 13:14       ` Ingo Molnar
2008-11-12 10:53 ` [PATCH 0/2] unlikely profiler and tracer Ingo Molnar
2008-11-12 13:00   ` Steven Rostedt
2008-11-12 13:07     ` Ingo Molnar
2008-11-12 15:36       ` Steven Rostedt
2008-11-12 18:21         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081112182131.GB4562@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tytso@mit.edu \
    --subject='Re: [PATCH 0/2] unlikely profiler and tracer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).