LKML Archive on
help / color / mirror / Atom feed
From: Mark Brown <>
To: Samuel Ortiz <>
Subject: Re: [PATCH 2.6.28] mfd: Correct WM8350 I2C return code usage
Date: Wed, 12 Nov 2008 20:00:07 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Nov 12, 2008 at 07:49:57PM +0100, Samuel Ortiz wrote:
> On Mon, Nov 10, 2008 at 01:41:17PM +0000, Mark Brown wrote:

> > The vendor BSP used for the WM8350 development provided an I2C driver
> > which incorrectly returned zero on succesful sends rather than the
> > number of transmitted bytes, an error which was then propagated into the
> > WM8350 I2C accessors.

> Shouldnt we fix the accessors behaviour instead ?
> Currently, that would mean fixing some of the wm8350-core static functions.
> Slightly bigger patch, but that would keep the i2c interface consistent.

I don't really understand what you mean by "keep the i2c interface
consistent" here?  The purpose of this abstraction is to abstract away
the control interface used to communicate with the chip since it
supports both I2C and SPI.

> What do you think ?

That would expose the details of the I2C API and the wire format used to
access the device over I2C to the WM8350 core which would mean the SPI
control code would have to jump through hoops to emulate it.  If the
device only had I2C control it would be better to just remove this
abstraction entirely and use the I2C API directly in the register access

  reply	other threads:[~2008-11-12 20:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 13:41 Mark Brown
2008-11-12 18:49 ` Samuel Ortiz
2008-11-12 20:00   ` Mark Brown [this message]
2008-11-12 23:06     ` Samuel Ortiz
2008-11-12 23:43       ` Mark Brown
2008-11-16 22:30         ` Samuel Ortiz
  -- strict thread matches above, loose matches on Subject: below --
2008-11-06 13:24 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH 2.6.28] mfd: Correct WM8350 I2C return code usage' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).