LKML Archive on
help / color / mirror / Atom feed
From: Samuel Ortiz <>
To: Mark Brown <>
Subject: Re: [PATCH 2.6.28] mfd: Correct WM8350 I2C return code usage
Date: Sun, 16 Nov 2008 23:30:14 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Nov 12, 2008 at 11:43:31PM +0000, Mark Brown wrote:
> > With this patch you're breaking that expectation because the read|write_dev()
> > I'd prefer to fix the callers code, so that we keep the expected semantics
> Just to clarify, when you say "expectation" and "fix" are you talking
> about your preference that the hardware access functions return the
> number of bytes read or written or is there something else going on
> here? 
No, definitely just my preference. I personnaly expect this kind of IO
routines to return the number of bytes read/written.

> To be honest I'm really not sure it's worth changing this - I'm having a
> hard time thinking of a user that would be able to do anything useful
> with a short access.  
I agree with that, yes.

> It also seems like it'd be a rather invasive
> change for an -rc.
Fair enough, I applied your patch, and sent Linus a pull request.


Intel Open Source Technology Centre

  reply	other threads:[~2008-11-16 22:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 13:41 Mark Brown
2008-11-12 18:49 ` Samuel Ortiz
2008-11-12 20:00   ` Mark Brown
2008-11-12 23:06     ` Samuel Ortiz
2008-11-12 23:43       ` Mark Brown
2008-11-16 22:30         ` Samuel Ortiz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-11-06 13:24 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH 2.6.28] mfd: Correct WM8350 I2C return code usage' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).