LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: David Sterba <dsterba@suse.cz>
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
	mfasheh@suse.com
Subject: Re: fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock
Date: Thu, 18 Nov 2010 15:42:16 -0800	[thread overview]
Message-ID: <20101118234216.GH19821@mail.oracle.com> (raw)
In-Reply-To: <20101102223601.GA27513@ds.suse.cz>

On Tue, Nov 02, 2010 at 11:36:02PM +0100, David Sterba wrote:
> coccinelle check scripts/coccinelle/locks/call_kern.cocci found that
> in fs/ocfs2/dlm/dlmdomain.c an allocation with GFP_KERNEL is done
> with locks held:
> 
> dlm_query_region_handler
>   spin_lock(dlm_domain_lock)
>     dlm_match_regions
>       kmalloc(GFP_KERNEL)
> 
> Change it to GFP_ATOMIC.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>
> CC: Joel Becker <joel.becker@oracle.com>
> CC: Mark Fasheh <mfasheh@suse.com>
> CC: ocfs2-devel@oss.oracle.com

	This patch is now in the fixes branch of ocfs2.git.

Joel

-- 

"Behind every successful man there's a lot of unsuccessful years."
        - Bob Brown

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

  reply	other threads:[~2010-11-18 23:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 22:36 David Sterba
2010-11-18 23:42 ` Joel Becker [this message]
2011-01-28  1:09 ` Andrew Morton
2011-01-28  1:28   ` [Ocfs2-devel] " Sunil Mushran
2011-01-28  1:48     ` Andrew Morton
2011-01-28  1:35   ` Joel Becker
2011-01-28  1:48     ` Andrew Morton
2011-01-28  2:33       ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118234216.GH19821@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --subject='Re: fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).