LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Daniel Kiper <dkiper@net-space.pl>,
	akpm@linux-foundation.org, andi.kleen@intel.com,
	haicheng.li@linux.intel.com, fengguang.wu@intel.com,
	jeremy@goop.org, dan.magenheimer@oracle.com, v.tolstov@selfip.ru,
	xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH 2/3] drivers/xen/balloon.c: Various balloon features and fixes
Date: Wed, 29 Dec 2010 16:19:03 +0100	[thread overview]
Message-ID: <20101229151903.GB2743@router-fw-old.local.net-space.pl> (raw)
In-Reply-To: <20101227150847.GA3728@dumpdata.com>

Hi,

On Mon, Dec 27, 2010 at 10:08:47AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 20, 2010 at 02:47:24PM +0100, Daniel Kiper wrote:
> > +
> > +		/*
> > +		 * state > 0: hungry,
> > +		 * state == 0: done or nothing to do,
> > +		 * state < 0: error, go to sleep.
>
> Would it be better to just have #defines for this?

Changed to enum. I will send new patch release today.

> > +	balloon_stats.schedule_delay = 1;
> > +	balloon_stats.max_schedule_delay = 32;
>
> How did you arrive at that number?

This is in seconds. Initial delay is 1 s.
It could not be greater than 32 s.
I think that those values are good for
default config because they provide good
resposivnes of balloon process and protect
before CPU exhaust by it during erros.
However, if those values are not acceptable
by user he/she could change them using sysfs.

Daniel

      parent reply	other threads:[~2010-12-29 15:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 13:47 Daniel Kiper
2010-12-20 14:51 ` [Xen-devel] " Ian Campbell
2010-12-29 15:01   ` Daniel Kiper
2010-12-27 15:08 ` Konrad Rzeszutek Wilk
2010-12-27 16:27   ` Vasiliy G Tolstov
2010-12-27 16:39     ` [Xen-devel] " Konrad Rzeszutek Wilk
2010-12-27 21:52       ` Vasiliy G Tolstov
2010-12-29 16:49         ` Daniel Kiper
2010-12-31 11:20           ` Pasi Kärkkäinen
2011-01-04 11:43             ` Ian Campbell
2011-02-03 15:14               ` Daniel Kiper
2010-12-29 15:19   ` Daniel Kiper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101229151903.GB2743@router-fw-old.local.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=akpm@linux-foundation.org \
    --cc=andi.kleen@intel.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=fengguang.wu@intel.com \
    --cc=haicheng.li@linux.intel.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=v.tolstov@selfip.ru \
    --cc=xen-devel@lists.xensource.com \
    --subject='Re: [PATCH 2/3] drivers/xen/balloon.c: Various balloon features and fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).