LKML Archive on
help / color / mirror / Atom feed
From: Vasily Khoruzhick <>
To: Anton Vorontsov <>
Cc:, Richard Purdie <>,
	"Arnaud Patard (Rtp)" <>
Subject: Re: [RFC PATCH 2/2] power_supply: Add new LED trigger charging-blink-solid-full
Date: Fri, 14 Jan 2011 18:37:24 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Friday 14 January 2011 18:18:51 Anton Vorontsov wrote:

> Strange, I got neither 0/2 nor 1/2.

Hmm, patches are definitely on ML, here's link to 1st patch on patchwork:

However, if you want, I can forward copy of 0/2 and 1/2 to you directly, but 
check your 'spam' folder first ;)

> Anyway, I'm fine with this particular patch, but to take 1/2 via
> battery-2.6.git I need Richard's Acked-by tag.


> > +		led_trigger_blink(psy->charging_blink_full_solid_trig,
> > +			&delay_on, &delay_off);
> I think it's better to allow passing NULL to led_trigger_blink()
> and thus avoid delay_{on,off} dummy variables.

It mimics led_blink_set function, and I prefer to keep it this way (just to 
keep consistency), or change led_blink_set behavior.


  reply	other threads:[~2011-01-14 16:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07 16:28 [RFC PATCH 0/2] LEDs: power_supply: Add ability to blink via simple trigger Vasily Khoruzhick
2011-01-07 16:28 ` [RFC PATCH 1/2] LEDs: " Vasily Khoruzhick
2011-01-07 16:28 ` [RFC PATCH 2/2] power_supply: Add new LED trigger charging-blink-solid-full Vasily Khoruzhick
2011-01-14 16:18   ` Anton Vorontsov
2011-01-14 16:37     ` Vasily Khoruzhick [this message]
2011-01-31 13:33   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH 2/2] power_supply: Add new LED trigger charging-blink-solid-full' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).