LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Thomas Chou <thomas@wytron.com.tw>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
nios2-dev@sopc.et.ntust.edu.tw,
Mike Frysinger <vapier@gentoo.org>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v2] spi: New driver for Altera SPI
Date: Mon, 17 Jan 2011 16:59:58 +1100 [thread overview]
Message-ID: <20110117165958.f89e8220.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1295243200-28230-1-git-send-email-thomas@wytron.com.tw>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Hi Thomas,
On Mon, 17 Jan 2011 13:46:40 +0800 Thomas Chou <thomas@wytron.com.tw> wrote:
>
> This patch adds a new SPI driver to support the Altera SOPC Builder
> SPI component. It uses the bitbanging library.
Just a general query.
> diff --git a/include/linux/spi/spi_altera.h b/include/linux/spi/spi_altera.h
> new file mode 100644
> index 0000000..b3d7f69
> --- /dev/null
> +++ b/include/linux/spi/spi_altera.h
> @@ -0,0 +1,12 @@
> +#ifndef _LINUX_SPI_SPI_ALTERA_H
> +#define _LINUX_SPI_SPI_ALTERA_H
> +
> +/*
> + * struct altera_spi_platform_data - platform data of the Altera SPI
> + * @interrupt: use intrrupt driven data transfer.
> + */
> +struct altera_spi_platform_data {
> + int interrupt;
> +};
Is there some reason that this struct definition cannot just be placed
in spi_altera.c and so save a whole extra file (and its inclusion)?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-01-17 6:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 6:03 [PATCH] " Thomas Chou
2011-01-17 5:46 ` [PATCH v2] " Thomas Chou
2011-01-17 5:59 ` Stephen Rothwell [this message]
2011-01-17 6:22 ` Thomas Chou
2011-01-17 6:45 ` Grant Likely
2011-01-17 7:04 ` [PATCH v3] " Thomas Chou
2011-01-17 7:27 ` Sinan Akman
2011-01-18 1:33 ` Thomas Chou
2011-01-19 1:36 ` Thomas Chou
2011-01-17 6:56 ` [PATCH v2] " Grant Likely
2011-01-17 7:13 ` [PATCH v4] " Thomas Chou
2011-01-17 7:42 ` Grant Likely
2011-01-24 6:38 ` [PATCH v5] " Thomas Chou
2011-02-03 10:02 ` [PATCH v6] " Thomas Chou
2011-02-03 17:34 ` Grant Likely
2011-02-05 13:08 ` Thomas Chou
2011-02-05 14:02 ` [PATCH v7] " Thomas Chou
2011-02-06 20:23 ` Peter Korsgaard
2011-02-08 2:43 ` Thomas Chou
2011-02-08 5:21 ` [PATCH v8] " Thomas Chou
2011-02-14 2:10 ` [PATCH v9] " Thomas Chou
2011-02-14 2:20 ` Ryan Mallon
2011-02-15 7:04 ` Thomas Chou
2011-02-15 9:12 ` Ryan Mallon
2011-02-15 19:42 ` Grant Likely
2011-02-15 21:58 ` Ryan Mallon
2011-02-16 2:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117165958.f89e8220.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dbrownell@users.sourceforge.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=nios2-dev@sopc.et.ntust.edu.tw \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=thomas@wytron.com.tw \
--cc=vapier@gentoo.org \
--subject='Re: [PATCH v2] spi: New driver for Altera SPI' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).