[PATCH V1 3/3] drivers/staging: kztmem: misc build/config

[PATCH V1 3/3] drivers/staging: kztmem: misc build/config

[Dan Magenheimer]

[PATCH V1 3/3] drivers/staging: kztmem: misc build/config

Makefiles and Kconfigs to build kztmem in drivers/staging

There is a dependency on xvmalloc.* which in 2.6.37 resides
in drivers/staging/zram.  Should this move or disappear,
some Makefile/Kconfig changes will be required.

Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>

---

Diffstat:
 drivers/staging/Kconfig                  |    2 ++
 drivers/staging/Makefile                 |    1 +
 drivers/staging/kztmem/Kconfig           |    8 ++++++++
 drivers/staging/kztmem/Makefile          |    1 +
 4 files changed, 12 insertions(+)

--- linux-2.6.37/drivers/staging/kztmem/Makefile	1969-12-31 17:00:00.000000000 -0700
+++ linux-2.6.37-kztmem/drivers/staging/kztmem/Makefile	2011-01-13 15:44:24.000000000 -0700
@@ -0,0 +1 @@
+obj-$(CONFIG_KZTMEM)	+=	kztmem.o tmem.o
--- linux-2.6.37/drivers/staging/kztmem/Kconfig	1969-12-31 17:00:00.000000000 -0700
+++ linux-2.6.37-kztmem/drivers/staging/kztmem/Kconfig	2011-01-13 15:44:24.000000000 -0700
@@ -0,0 +1,8 @@
+config KZTMEM
+	tristate "In-kernel transcendent memory using compression"
+	select XVMALLOC
+	select LZO_COMPRESS
+	select LZO_DECOMPRESS
+	default n
+	help
+	  In-kernel transcendent memory using compression
--- linux-2.6.37/drivers/staging/Makefile	2011-01-04 17:50:19.000000000 -0700
+++ linux-2.6.37-kztmem/drivers/staging/Makefile	2011-01-13 15:44:24.000000000 -0700
@@ -44,6 +44,7 @@ obj-$(CONFIG_VME_BUS)		+= vme/
 obj-$(CONFIG_MRST_RAR_HANDLER)	+= memrar/
 obj-$(CONFIG_IIO)		+= iio/
 obj-$(CONFIG_ZRAM)		+= zram/
+obj-$(CONFIG_KZTMEM)		+= kztmem/
 obj-$(CONFIG_WLAGS49_H2)	+= wlags49_h2/
 obj-$(CONFIG_WLAGS49_H25)	+= wlags49_h25/
 obj-$(CONFIG_BATMAN_ADV)	+= batman-adv/
--- linux-2.6.37/drivers/staging/Kconfig	2011-01-04 17:50:19.000000000 -0700
+++ linux-2.6.37-kztmem/drivers/staging/Kconfig	2011-01-13 15:44:24.000000000 -0700
@@ -123,6 +123,8 @@ source "drivers/staging/iio/Kconfig"
 
 source "drivers/staging/zram/Kconfig"
 
+source "drivers/staging/kztmem/Kconfig"
+
 source "drivers/staging/wlags49_h2/Kconfig"
 
 source "drivers/staging/wlags49_h25/Kconfig"

Re: [PATCH V1 3/3] drivers/staging: kztmem: misc build/config

[Greg KH]

On Tue, Jan 18, 2011 at 09:21:51AM -0800, Dan Magenheimer wrote:
> [PATCH V1 3/3] drivers/staging: kztmem: misc build/config
> 
> Makefiles and Kconfigs to build kztmem in drivers/staging
> 
> There is a dependency on xvmalloc.* which in 2.6.37 resides
> in drivers/staging/zram.  Should this move or disappear,
> some Makefile/Kconfig changes will be required.

There is some other kind of dependancy as well, because I get the
following errors when building:

drivers/staging/kztmem/kztmem.c:34:2: error: #error "kztmem is useless without CONFIG_CLEANCACHE or CONFIG_FRONTSWAP"
drivers/staging/kztmem/kztmem.c:531:13: warning: ‘zbud_init’ defined but not used
drivers/staging/kztmem/kztmem.c:883:28: warning: ‘kztmem_hostops’ defined but not used
drivers/staging/kztmem/kztmem.c:988:27: warning: ‘kztmem_pamops’ defined but not used
drivers/staging/kztmem/kztmem.c:1063:30: warning: ‘kztmem_cpu_notifier_block’ defined but not used
drivers/staging/kztmem/kztmem.c:1201:24: warning: ‘kztmem_shrinker’ defined but not used
drivers/staging/kztmem/kztmem.c:1210:12: warning: ‘kztmem_put_page’ defined but not used
drivers/staging/kztmem/kztmem.c:1242:12: warning: ‘kztmem_get_page’ defined but not used
drivers/staging/kztmem/kztmem.c:1259:12: warning: ‘kztmem_flush_page’ defined but not used
drivers/staging/kztmem/kztmem.c:1278:12: warning: ‘kztmem_flush_object’ defined but not used
drivers/staging/kztmem/kztmem.c:1297:12: warning: ‘kztmem_destroy_pool’ defined but not used
drivers/staging/kztmem/kztmem.c:1320:12: warning: ‘kztmem_new_pool’ defined but not used
drivers/staging/kztmem/kztmem.c:1558:19: warning: ‘enable_kztmem’ defined but not used
drivers/staging/kztmem/kztmem.c:1569:19: warning: ‘no_cleancache’ defined but not used
drivers/staging/kztmem/kztmem.c:1579:19: warning: ‘no_frontswap’ defined but not used

If you require a kbuild dependancy, then put it in your Kconfig file
please, don't break the build.

I'll not apply these patches for now until that's fixed up.

thanks,

greg k-h

RE: [PATCH V1 3/3] drivers/staging: kztmem: misc build/config

[Dan Magenheimer]

> If you require a kbuild dependancy, then put it in your Kconfig file
> please, don't break the build.
> 
> I'll not apply these patches for now until that's fixed up.

Oops, sorry, missed that line in my Kconfig.  Will re-post.

Thanks,
Dan

RE: [PATCH V1 3/3] drivers/staging: kztmem: misc build/config

[Dan Magenheimer]

> From: Greg KH [mailto:greg@kroah.com]
> Subject: Re: [PATCH V1 3/3] drivers/staging: kztmem: misc build/config
> 
> On Tue, Jan 18, 2011 at 09:21:51AM -0800, Dan Magenheimer wrote:
> > [PATCH V1 3/3] drivers/staging: kztmem: misc build/config
> >
> > Makefiles and Kconfigs to build kztmem in drivers/staging
> >
> > There is a dependency on xvmalloc.* which in 2.6.37 resides
> > in drivers/staging/zram.  Should this move or disappear,
> > some Makefile/Kconfig changes will be required.
> 
> There is some other kind of dependancy as well, because I get the
> following errors when building:
> : 
> If you require a kbuild dependancy, then put it in your Kconfig file
> please, don't break the build.
> 
> I'll not apply these patches for now until that's fixed up.
> 
> thanks,
> greg k-h

Hi Greg --

Just wanted to confirm that this is now fixed and hope that you
can now apply BUT note that per agreement with Nitin Gupta [1]
the patchset has been modified to be named zcache and the
renamed patchset (with the proper kbuild dependency) has been
posted at [2].

ALSO, could you please confirm the path by which this patchset
will find its way upstream?  I see from your blog [3] that after
you apply it, I should be able to see it in sfr's linux-next
tree [4] which IIUC sfr pulls regularly from your staging-next
tree [5].  And I think at the next merge window, YOU will
provide the pull request to Linus included with any other
staging drivers?  Is this all correct?

Sorry for the driver-staging-newbie question but your blog
entry is 2 years old and I'd like to (1) ensure that I don't
drop some important task *I* still need to do and (2) be able
to track the progress of zcache through the various trees as
a self-educational exercise.

Thanks,
Dan

[1] https://lkml.org/lkml/2011/2/5/181 
[2] https://lkml.org/lkml/2011/2/6/346
    https://lkml.org/lkml/2011/2/6/345 
    https://lkml.org/lkml/2011/2/6/344 
    https://lkml.org/lkml/2011/2/6/343 
[3] http://www.kroah.com/log/linux/linux-staging-update.html 
[4] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git 
[5] http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=shortlog;h=refs/heads/staging-next