LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit
@ 2011-01-14 19:25 Sergey Senozhatsky
2011-01-20 0:32 ` Jens Axboe
2011-01-20 11:32 ` Vivek Goyal
0 siblings, 2 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2011-01-14 19:25 UTC (permalink / raw)
To: Jens Axboe
Cc: Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
Performing
$ sudo mount -o loop -o umask=0 /dev/sdb1 /mnt/
mount: wrong fs type, bad option, bad superblock on /dev/loop0,
missing codepage or helper program, or other error
In some cases useful info is found in syslog - try
dmesg | tail or so
$ sudo modprobe -r loop
results in oops:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
IP: [<ffffffff812479d4>] do_raw_spin_lock+0x14/0x122
Process modprobe (pid: 6189, threadinfo ffff88009a898000, task ffff880154a88000)
Call Trace:
[<ffffffff81486788>] _raw_spin_lock_irq+0x4a/0x51
[<ffffffff8123404b>] ? blk_throtl_exit+0x3b/0xa0
[<ffffffff8105b120>] ? cancel_delayed_work_sync+0xd/0xf
[<ffffffff8123404b>] blk_throtl_exit+0x3b/0xa0
[<ffffffff81229bc8>] blk_release_queue+0x21/0x65
[<ffffffff8123bb06>] kobject_release+0x51/0x66
[<ffffffff8123bab5>] ? kobject_release+0x0/0x66
[<ffffffff8123ce1e>] kref_put+0x43/0x4d
[<ffffffff8123ba27>] kobject_put+0x47/0x4b
[<ffffffff8122717c>] blk_cleanup_queue+0x56/0x5b
[<ffffffffa01c3824>] loop_exit+0x68/0x844 [loop]
[<ffffffff8107cccc>] sys_delete_module+0x1e8/0x25b
[<ffffffff814864c9>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[<ffffffff81002112>] system_call_fastpath+0x16/0x1b
because of an attempt to acquire NULL queue_lock.
I added the same lines as in blk_queue_make_request -
`fall back to embedded per-queue lock'.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
drivers/block/loop.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 44e18c0..49e6a54 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1641,6 +1641,9 @@ out:
static void loop_free(struct loop_device *lo)
{
+ if (!lo->lo_queue->queue_lock)
+ lo->lo_queue->queue_lock = &lo->lo_queue->__queue_lock;
+
blk_cleanup_queue(lo->lo_queue);
put_disk(lo->lo_disk);
list_del(&lo->lo_list);
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit
2011-01-14 19:25 [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit Sergey Senozhatsky
@ 2011-01-20 0:32 ` Jens Axboe
2011-01-20 11:32 ` Vivek Goyal
1 sibling, 0 replies; 8+ messages in thread
From: Jens Axboe @ 2011-01-20 0:32 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
On 2011-01-14 12:25, Sergey Senozhatsky wrote:
> Performing
> $ sudo mount -o loop -o umask=0 /dev/sdb1 /mnt/
> mount: wrong fs type, bad option, bad superblock on /dev/loop0,
> missing codepage or helper program, or other error
> In some cases useful info is found in syslog - try
> dmesg | tail or so
>
> $ sudo modprobe -r loop
>
> results in oops:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
> IP: [<ffffffff812479d4>] do_raw_spin_lock+0x14/0x122
> Process modprobe (pid: 6189, threadinfo ffff88009a898000, task ffff880154a88000)
> Call Trace:
> [<ffffffff81486788>] _raw_spin_lock_irq+0x4a/0x51
> [<ffffffff8123404b>] ? blk_throtl_exit+0x3b/0xa0
> [<ffffffff8105b120>] ? cancel_delayed_work_sync+0xd/0xf
> [<ffffffff8123404b>] blk_throtl_exit+0x3b/0xa0
> [<ffffffff81229bc8>] blk_release_queue+0x21/0x65
> [<ffffffff8123bb06>] kobject_release+0x51/0x66
> [<ffffffff8123bab5>] ? kobject_release+0x0/0x66
> [<ffffffff8123ce1e>] kref_put+0x43/0x4d
> [<ffffffff8123ba27>] kobject_put+0x47/0x4b
> [<ffffffff8122717c>] blk_cleanup_queue+0x56/0x5b
> [<ffffffffa01c3824>] loop_exit+0x68/0x844 [loop]
> [<ffffffff8107cccc>] sys_delete_module+0x1e8/0x25b
> [<ffffffff814864c9>] ? trace_hardirqs_on_thunk+0x3a/0x3f
> [<ffffffff81002112>] system_call_fastpath+0x16/0x1b
>
>
> because of an attempt to acquire NULL queue_lock.
> I added the same lines as in blk_queue_make_request -
> `fall back to embedded per-queue lock'.
Queued up for 2.6.38, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit
2011-01-14 19:25 [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit Sergey Senozhatsky
2011-01-20 0:32 ` Jens Axboe
@ 2011-01-20 11:32 ` Vivek Goyal
2011-01-20 12:58 ` [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2) Sergey Senozhatsky
1 sibling, 1 reply; 8+ messages in thread
From: Vivek Goyal @ 2011-01-20 11:32 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Jens Axboe, Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
On Fri, Jan 14, 2011 at 09:25:32PM +0200, Sergey Senozhatsky wrote:
> Performing
> $ sudo mount -o loop -o umask=0 /dev/sdb1 /mnt/
> mount: wrong fs type, bad option, bad superblock on /dev/loop0,
> missing codepage or helper program, or other error
> In some cases useful info is found in syslog - try
> dmesg | tail or so
>
> $ sudo modprobe -r loop
>
> results in oops:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
> IP: [<ffffffff812479d4>] do_raw_spin_lock+0x14/0x122
> Process modprobe (pid: 6189, threadinfo ffff88009a898000, task ffff880154a88000)
> Call Trace:
> [<ffffffff81486788>] _raw_spin_lock_irq+0x4a/0x51
> [<ffffffff8123404b>] ? blk_throtl_exit+0x3b/0xa0
> [<ffffffff8105b120>] ? cancel_delayed_work_sync+0xd/0xf
> [<ffffffff8123404b>] blk_throtl_exit+0x3b/0xa0
> [<ffffffff81229bc8>] blk_release_queue+0x21/0x65
> [<ffffffff8123bb06>] kobject_release+0x51/0x66
> [<ffffffff8123bab5>] ? kobject_release+0x0/0x66
> [<ffffffff8123ce1e>] kref_put+0x43/0x4d
> [<ffffffff8123ba27>] kobject_put+0x47/0x4b
> [<ffffffff8122717c>] blk_cleanup_queue+0x56/0x5b
> [<ffffffffa01c3824>] loop_exit+0x68/0x844 [loop]
> [<ffffffff8107cccc>] sys_delete_module+0x1e8/0x25b
> [<ffffffff814864c9>] ? trace_hardirqs_on_thunk+0x3a/0x3f
> [<ffffffff81002112>] system_call_fastpath+0x16/0x1b
>
>
> because of an attempt to acquire NULL queue_lock.
> I added the same lines as in blk_queue_make_request -
> `fall back to embedded per-queue lock'.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> ---
>
> drivers/block/loop.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 44e18c0..49e6a54 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1641,6 +1641,9 @@ out:
>
> static void loop_free(struct loop_device *lo)
> {
> + if (!lo->lo_queue->queue_lock)
> + lo->lo_queue->queue_lock = &lo->lo_queue->__queue_lock;
> +
> blk_cleanup_queue(lo->lo_queue);
> put_disk(lo->lo_disk);
> list_del(&lo->lo_list);
IIUC, the issue here seems to be that we allocated a request queue but
never initiliazed it and then called blk_cleanup_queue() on that.
I noticed in loop driver there is another blk_cleanup_queue() call
in loop_alloc() if memory allocation fails. There also we will run into
similar issue.
IMHO, a better place to fix this might be blk_release_queue() where we
can default to q->__spin_lock if we are cleaning up an uninitialized queue.
That way we shall not have to fix inidividual drivers. And it also
does not sound right to expect a driver to make sure queue lock is
initialized before it calls blk_cleanup_queue() on the queue.
Thanks
Vivek
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2)
2011-01-20 11:32 ` Vivek Goyal
@ 2011-01-20 12:58 ` Sergey Senozhatsky
2011-01-20 14:35 ` Vivek Goyal
0 siblings, 1 reply; 8+ messages in thread
From: Sergey Senozhatsky @ 2011-01-20 12:58 UTC (permalink / raw)
To: Jens Axboe
Cc: Vivek Goyal, Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
Performing
$ sudo mount -o loop -o umask=0 /dev/sdb1 /mnt/
mount: wrong fs type, bad option, bad superblock on /dev/loop0,
missing codepage or helper program, or other error
In some cases useful info is found in syslog - try
dmesg | tail or so
$ sudo modprobe -r loop
results in oops:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
IP: [<ffffffff812479d4>] do_raw_spin_lock+0x14/0x122
Process modprobe (pid: 6189, threadinfo ffff88009a898000, task ffff880154a88000)
Call Trace:
[<ffffffff81486788>] _raw_spin_lock_irq+0x4a/0x51
[<ffffffff8123404b>] ? blk_throtl_exit+0x3b/0xa0
[<ffffffff8105b120>] ? cancel_delayed_work_sync+0xd/0xf
[<ffffffff8123404b>] blk_throtl_exit+0x3b/0xa0
[<ffffffff81229bc8>] blk_release_queue+0x21/0x65
[<ffffffff8123bb06>] kobject_release+0x51/0x66
[<ffffffff8123bab5>] ? kobject_release+0x0/0x66
[<ffffffff8123ce1e>] kref_put+0x43/0x4d
[<ffffffff8123ba27>] kobject_put+0x47/0x4b
[<ffffffff8122717c>] blk_cleanup_queue+0x56/0x5b
[<ffffffffa01c3824>] loop_exit+0x68/0x844 [loop]
[<ffffffff8107cccc>] sys_delete_module+0x1e8/0x25b
[<ffffffff814864c9>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[<ffffffff81002112>] system_call_fastpath+0x16/0x1b
because of an attempt to acquire NULL queue_lock.
I added the same lines as in blk_queue_make_request -
`fall back to embedded per-queue lock'.
v2: According to comment by Vivek Goyal, queue_lock NULL check and fix moved
out from loop driver code to blk_cleanup_queue, which is more general approach.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
block/blk-core.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 2f4002f..45073ab 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -458,6 +458,10 @@ void blk_put_queue(struct request_queue *q)
void blk_cleanup_queue(struct request_queue *q)
{
+ /* fall back to our embedded per-queue locks */
+ if (!q->queue_lock)
+ q->queue_lock = &q->__queue_lock;
+
/*
* We know we have process context here, so we can be a little
* cautious and ensure that pending block actions on this device
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2)
2011-01-20 12:58 ` [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2) Sergey Senozhatsky
@ 2011-01-20 14:35 ` Vivek Goyal
2011-01-20 15:18 ` Sergey Senozhatsky
0 siblings, 1 reply; 8+ messages in thread
From: Vivek Goyal @ 2011-01-20 14:35 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Jens Axboe, Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
On Thu, Jan 20, 2011 at 02:58:49PM +0200, Sergey Senozhatsky wrote:
> Performing
> $ sudo mount -o loop -o umask=0 /dev/sdb1 /mnt/
> mount: wrong fs type, bad option, bad superblock on /dev/loop0,
> missing codepage or helper program, or other error
> In some cases useful info is found in syslog - try
> dmesg | tail or so
>
> $ sudo modprobe -r loop
>
> results in oops:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
> IP: [<ffffffff812479d4>] do_raw_spin_lock+0x14/0x122
> Process modprobe (pid: 6189, threadinfo ffff88009a898000, task ffff880154a88000)
> Call Trace:
> [<ffffffff81486788>] _raw_spin_lock_irq+0x4a/0x51
> [<ffffffff8123404b>] ? blk_throtl_exit+0x3b/0xa0
> [<ffffffff8105b120>] ? cancel_delayed_work_sync+0xd/0xf
> [<ffffffff8123404b>] blk_throtl_exit+0x3b/0xa0
> [<ffffffff81229bc8>] blk_release_queue+0x21/0x65
> [<ffffffff8123bb06>] kobject_release+0x51/0x66
> [<ffffffff8123bab5>] ? kobject_release+0x0/0x66
> [<ffffffff8123ce1e>] kref_put+0x43/0x4d
> [<ffffffff8123ba27>] kobject_put+0x47/0x4b
> [<ffffffff8122717c>] blk_cleanup_queue+0x56/0x5b
> [<ffffffffa01c3824>] loop_exit+0x68/0x844 [loop]
> [<ffffffff8107cccc>] sys_delete_module+0x1e8/0x25b
> [<ffffffff814864c9>] ? trace_hardirqs_on_thunk+0x3a/0x3f
> [<ffffffff81002112>] system_call_fastpath+0x16/0x1b
>
>
> because of an attempt to acquire NULL queue_lock.
> I added the same lines as in blk_queue_make_request -
> `fall back to embedded per-queue lock'.
>
> v2: According to comment by Vivek Goyal, queue_lock NULL check and fix moved
> out from loop driver code to blk_cleanup_queue, which is more general approach.
>
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> ---
>
> block/blk-core.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 2f4002f..45073ab 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -458,6 +458,10 @@ void blk_put_queue(struct request_queue *q)
>
> void blk_cleanup_queue(struct request_queue *q)
> {
> + /* fall back to our embedded per-queue locks */
> + if (!q->queue_lock)
> + q->queue_lock = &q->__queue_lock;
> +
Hi Sergey,
Can we expand a little bit on comment that why do we need to have
q->queue_lock initialized here now. Basically in the past nobody tried
to take q->queue_lock in blk_cleanup_queue() path hence things just
worked. Now blk throttling code is new and it takes q->queue_lock hence we
run into issues. This could be true for some other future code too.
Secondly currently blk throttle code seems to be the only user dependent
on this lock initialization. So it might make sense to move this code
closer to the actual call and blk_release_queue() might be even better
place to do it atleast for now.
Thanks
Vivek
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2)
2011-01-20 14:35 ` Vivek Goyal
@ 2011-01-20 15:18 ` Sergey Senozhatsky
2011-01-20 15:43 ` Vivek Goyal
0 siblings, 1 reply; 8+ messages in thread
From: Sergey Senozhatsky @ 2011-01-20 15:18 UTC (permalink / raw)
To: Vivek Goyal
Cc: Jens Axboe, Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On (01/20/11 09:35), Vivek Goyal wrote:
> Hi Sergey,
>
Hi Vivek,
> Can we expand a little bit on comment that why do we need to have
> q->queue_lock initialized here now. Basically in the past nobody tried
> to take q->queue_lock in blk_cleanup_queue() path hence things just
> worked. Now blk throttling code is new and it takes q->queue_lock hence we
> run into issues. This could be true for some other future code too.
>
> Secondly currently blk throttle code seems to be the only user dependent
> on this lock initialization. So it might make sense to move this code
> closer to the actual call and blk_release_queue() might be even better
> place to do it atleast for now.
>
I'm afraid it's not safe to move NULL-check-and-fix out from blk_cleanup_queue,
since we're performing elevator_exit(q->elevator) call, which may depend on
q->queue_lock. For example, (./cfq-iosched.c: .elevator_exit_fn = cfq_exit_queue)
cfq_exit_queue uses q->queue_lock.
Sergey
[-- Attachment #2: Type: application/pgp-signature, Size: 316 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2)
2011-01-20 15:18 ` Sergey Senozhatsky
@ 2011-01-20 15:43 ` Vivek Goyal
2011-01-21 12:55 ` [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v3) Sergey Senozhatsky
0 siblings, 1 reply; 8+ messages in thread
From: Vivek Goyal @ 2011-01-20 15:43 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Jens Axboe, Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
On Thu, Jan 20, 2011 at 05:18:22PM +0200, Sergey Senozhatsky wrote:
> On (01/20/11 09:35), Vivek Goyal wrote:
> > Hi Sergey,
> >
>
> Hi Vivek,
>
> > Can we expand a little bit on comment that why do we need to have
> > q->queue_lock initialized here now. Basically in the past nobody tried
> > to take q->queue_lock in blk_cleanup_queue() path hence things just
> > worked. Now blk throttling code is new and it takes q->queue_lock hence we
> > run into issues. This could be true for some other future code too.
> >
> > Secondly currently blk throttle code seems to be the only user dependent
> > on this lock initialization. So it might make sense to move this code
> > closer to the actual call and blk_release_queue() might be even better
> > place to do it atleast for now.
> >
>
> I'm afraid it's not safe to move NULL-check-and-fix out from blk_cleanup_queue,
> since we're performing elevator_exit(q->elevator) call, which may depend on
> q->queue_lock. For example, (./cfq-iosched.c: .elevator_exit_fn = cfq_exit_queue)
> cfq_exit_queue uses q->queue_lock.
ok, actually cfq_exit_queue() will be called only if elevator has been
initilialzed and if elevator has been initialialized that means
q->queue_lock also has been initilalized so that should not be a problem.
I am not very particular about this thing. So I will leave it to you.
Thanks
Vivek
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v3)
2011-01-20 15:43 ` Vivek Goyal
@ 2011-01-21 12:55 ` Sergey Senozhatsky
0 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2011-01-21 12:55 UTC (permalink / raw)
To: Vivek Goyal
Cc: Jens Axboe, Philipp Reisner, Andrew Morton, Lars Ellenberg,
Stephen M. Cameron, linux-kernel
Performing
$ sudo mount -o loop -o umask=0 /dev/sdb1 /mnt/
mount: wrong fs type, bad option, bad superblock on /dev/loop0,
missing codepage or helper program, or other error
In some cases useful info is found in syslog - try
dmesg | tail or so
$ sudo modprobe -r loop
results in oops:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
IP: [<ffffffff812479d4>] do_raw_spin_lock+0x14/0x122
Process modprobe (pid: 6189, threadinfo ffff88009a898000, task
ffff880154a88000)
Call Trace:
[<ffffffff81486788>] _raw_spin_lock_irq+0x4a/0x51
[<ffffffff8123404b>] ? blk_throtl_exit+0x3b/0xa0
[<ffffffff8105b120>] ? cancel_delayed_work_sync+0xd/0xf
[<ffffffff8123404b>] blk_throtl_exit+0x3b/0xa0
[<ffffffff81229bc8>] blk_release_queue+0x21/0x65
[<ffffffff8123bb06>] kobject_release+0x51/0x66
[<ffffffff8123bab5>] ? kobject_release+0x0/0x66
[<ffffffff8123ce1e>] kref_put+0x43/0x4d
[<ffffffff8123ba27>] kobject_put+0x47/0x4b
[<ffffffff8122717c>] blk_cleanup_queue+0x56/0x5b
[<ffffffffa01c3824>] loop_exit+0x68/0x844 [loop]
[<ffffffff8107cccc>] sys_delete_module+0x1e8/0x25b
[<ffffffff814864c9>] ? trace_hardirqs_on_thunk+0x3a/0x3f
[<ffffffff81002112>] system_call_fastpath+0x16/0x1b
because of an attempt to acquire NULL queue_lock.
Added the same lines as in blk_queue_make_request -
`fall back to embedded per-queue lock' - when call blk_release_queue on
allocated but not initialized queue.
v2: According to comment by Vivek Goyal, queue_lock NULL check and fix moved
out from loop driver code to blk_release_queue, which is more general
approach.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
block/blk-sysfs.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 41fb691..b8ca1f7 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -471,6 +471,12 @@ static void blk_release_queue(struct kobject *kobj)
blk_sync_queue(q);
+ /* It's possible that blk_release_queue will be called on allocated
+ * but never initilalized queue. Fall back to our embedded per-queue
+ * locks in this case. */
+ if (!q->queue_lock)
+ q->queue_lock = &q->__queue_lock;
+
blk_throtl_exit(q);
if (rl->rq_pool)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-01-21 12:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-14 19:25 [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit Sergey Senozhatsky
2011-01-20 0:32 ` Jens Axboe
2011-01-20 11:32 ` Vivek Goyal
2011-01-20 12:58 ` [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v2) Sergey Senozhatsky
2011-01-20 14:35 ` Vivek Goyal
2011-01-20 15:18 ` Sergey Senozhatsky
2011-01-20 15:43 ` Vivek Goyal
2011-01-21 12:55 ` [PATCH] loop: queue_lock NULL pointer derefence in blk_throtl_exit (v3) Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).