LKML Archive on
help / color / mirror / Atom feed
From: Felipe Balbi <>
To: John Ogness <>
	Linux OMAP Mailing List <>,
	Linux ARM Kernel Mailing List 
Subject: Re: [PATCH v2] omap2: fix DPLL_FREQSEL calculation
Date: Fri, 21 Jan 2011 05:15:53 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Jan 20, 2011 at 03:29:50PM +0100, John Ogness wrote:
> On 2011-01-20, Felipe Balbi <> wrote:
> > scripts/ would've helped you getting a better Cc
> > list. I'm adding linux-omap and lakml
> Thanks.
> After investigating the issue further it seems that I had it
> backwards. The value of "n" is the value to divide by, not the value
> that goes in the register. This means that it is _dpll_test_fint()
> that is doing it incorrectly. Here is a new version of the patch to
> fix the right function.

you might want to look at Documentation/SubmittingPatches before sending
these patches. If anyone applies this patch of yours the commitlog will
have all the comments you've made above. Generally, patches are
"standalone" emails, without a discussion on them, if you want to add
comments which aren't supposed to go into commit log, then do so after
the tear line (---) and before the diff --git line; that way, git will
know it must drop that part of the comments.


  reply	other threads:[~2011-01-21  3:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 10:42 [PATCH] " John Ogness
2011-01-20 11:16 ` Felipe Balbi
2011-01-20 14:29   ` [PATCH v2] " John Ogness
2011-01-21  3:15     ` Felipe Balbi [this message]
2011-01-21  8:33       ` [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL John Ogness
2011-02-08  3:09         ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] omap2: fix DPLL_FREQSEL calculation' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).