LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chris Clayton <chris2553@googlemail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Disable high-precision vblank timestamping for UMS
Date: Sun, 23 Jan 2011 11:28:22 +0000	[thread overview]
Message-ID: <201101231128.22951.chris2553@googlemail.com> (raw)
In-Reply-To: <1295779801-8118-1-git-send-email-chris@chris-wilson.co.uk>

Hi Chris,

On Sunday 23 January 2011, Chris Wilson wrote:
> We only have sufficient information for accurate (sub-frame) timestamping
> when the modesetting is under our control.
>
> Reported-by: Chris Clayton <chris2553@googlemail.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c
> b/drivers/gpu/drm/i915/i915_drv.c index 59eb19b..66796bb 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -752,6 +752,9 @@ static int __init i915_init(void)
>  		driver.driver_features &= ~DRIVER_MODESET;
>  #endif
>
> +	if (!(driver.driver_features & DRIVER_MODESET))
> +		driver.get_vblank_timestamp = NULL;
> +
>  	return drm_init(&driver);
>  }

With this patch (and the earlier one) applied, X still doesn't start. At the end 
of xorg's log file I see:

Fatal server error:
Failure to wait for IRQ: No such device

and in the kernel log I see:

Jan 23 11:15:25 upstairs kernel: [drm] Initialized drm 1.1.0 20060810
Jan 23 11:15:26 upstairs kernel: pci 0000:00:02.0: PCI INT A -> GSI 16 (level, 
low) -> IRQ 16
Jan 23 11:15:26 upstairs kernel: pci 0000:00:02.0: setting latency timer to 64
Jan 23 11:15:26 upstairs kernel: ioremap error for 0xbdce0000-0xbdce3000, 
requested 0x10, got 0x0
Jan 23 11:15:26 upstairs kernel: [drm] Supports vblank timestamp caching Rev 1 
(10.10.2010).
Jan 23 11:15:26 upstairs kernel: [drm] No driver support for vblank timestamp 
query.
Jan 23 11:15:26 upstairs kernel: [drm] Initialized i915 1.6.0 20080730 for 
0000:00:02.0 on minor 0

Chris

-- 
The more I see, the more I know. The more I know, the less I understand. 
Changing Man - Paul Weller

  reply	other threads:[~2011-01-23 11:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <:201101220935.03623.chris2553@googlemail.com>
2011-01-22 10:11 ` [PATCH] drm/i915: Increase the amount of defense before computing vblank timestamps Chris Wilson
2011-01-22 11:18   ` Chris Clayton
2011-01-22 18:01     ` Chris Wilson
2011-01-23  8:56       ` Chris Clayton
2011-01-23  9:32         ` Chris Clayton
2011-01-23 10:50           ` [PATCH] drm/i915: Disable high-precision vblank timestamping for UMS Chris Wilson
2011-01-23 11:28             ` Chris Clayton [this message]
2011-01-23 12:44               ` Chris Wilson
2011-01-23 12:55                 ` Chris Clayton
2011-01-23 13:06               ` [PATCH] drm/i915: Handle the no-interrupts case for UMS by polling Chris Wilson
2011-01-23 15:38                 ` Chris Clayton
2011-01-23 15:59                   ` Chris Wilson
2011-02-10 19:58                     ` Chris Clayton
2011-02-10 20:37                       ` Chris Wilson
2011-01-23 10:52           ` [PATCH] drm/i915: Increase the amount of defense before computing vblank timestamps Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101231128.22951.chris2553@googlemail.com \
    --to=chris2553@googlemail.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] drm/i915: Disable high-precision vblank timestamping for UMS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).