LKML Archive on
help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <>
To: Jesper Juhl <>
	Balbir Singh <>,
	Daisuke Nishimura <>,
	Pavel Emelianov <>,
	"Kirill A. Shutemov" <>
Subject: Re: [PATCH] Fix uninitialized variable use in mm/memcontrol.c::mem_cgroup_move_parent()
Date: Mon, 24 Jan 2011 09:08:44 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, 22 Jan 2011 20:51:32 +0100 (CET)
Jesper Juhl <> wrote:

> In mm/memcontrol.c::mem_cgroup_move_parent() there's a path that jumps to 
> the 'put_back' label
>   	ret = __mem_cgroup_try_charge(NULL, gfp_mask, &parent, false, charge);
>   	if (ret || !parent)
>   		goto put_back;
>  where we'll 
>   	if (charge > PAGE_SIZE)
>   		compound_unlock_irqrestore(page, flags);
> but, we have not assigned anything to 'flags' at this point, nor have we 
> called 'compound_lock_irqsave()' (which is what sets 'flags').
> So, I believe the 'put_back' label should be moved below the call to 
> compound_unlock_irqrestore() as per this patch. 
> Signed-off-by: Jesper Juhl <>

Thank you.

Acked-by: KAMEZAWA Hiroyuki <>

Andrew, I'll move my new patces onto this. So, please pick this one 1st.

      reply	other threads:[~2011-01-24  0:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-22 19:51 Jesper Juhl
2011-01-24  0:08 ` KAMEZAWA Hiroyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Fix uninitialized variable use in mm/memcontrol.c::mem_cgroup_move_parent()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).