LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Cc: akpm@linux-foundation.org, Richard Purdie <rpurdie@rpsys.net>
Subject: [PATCH -mmotm] backlight: apple_bl depends on ACPI
Date: Wed, 26 Jan 2011 11:16:02 -0800	[thread overview]
Message-ID: <20110126111602.7bfea64e.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201101260021.p0Q0LxsS016458@imap1.linux-foundation.org>

From: Randy Dunlap <randy.dunlap@oracle.com>

apple_bl uses ACPI interfaces (data & code), so it should depend on ACPI.

drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/video/backlight/apple_bl.c:201: warning: 'struct acpi_device' declared inside parameter list
drivers/video/backlight/apple_bl.c:215: error: variable 'apple_bl_driver' has initializer but incomplete type
drivers/video/backlight/apple_bl.c:216: error: unknown field 'name' specified in initializer
drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:217: error: unknown field 'ids' specified in initializer
drivers/video/backlight/apple_bl.c:217: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:217: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:218: error: unknown field 'ops' specified in initializer
drivers/video/backlight/apple_bl.c:218: error: extra brace group at end of initializer
drivers/video/backlight/apple_bl.c:218: error: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:221: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:221: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:226: error: implicit declaration of function 'acpi_bus_register_driver'
drivers/video/backlight/apple_bl.c:231: error: implicit declaration of function 'acpi_bus_unregister_driver'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
 drivers/video/backlight/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- mmotm-2011-0125-1547.orig/drivers/video/backlight/Kconfig
+++ mmotm-2011-0125-1547/drivers/video/backlight/Kconfig
@@ -238,10 +238,10 @@ config BACKLIGHT_MAX8925
 
 config BACKLIGHT_APPLE
        tristate "Apple Backlight Driver"
-       depends on X86
+       depends on X86 && ACPI
        help
          If you have an Intel-based Apple say Y to enable a driver for its
-	 backlight
+	 backlight.
 
 config BACKLIGHT_TOSA
 	tristate "Sharp SL-6000 Backlight Driver"

  parent reply	other threads:[~2011-01-26 19:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 23:48 mmotm 2011-01-25-15-47 uploaded akpm
2011-01-26 10:20 ` [patch] epoll-fix-compiler-warning-and-optimize-the-non-blocking-path-fix Johannes Weiner
2011-01-26 15:05   ` Davide Libenzi
2011-01-26 19:16 ` Randy Dunlap [this message]
2011-01-31 22:31   ` [PATCH -mmotm] backlight: apple_bl depends on ACPI Matthew Garrett
2011-02-03  7:39 ` epoll broken [was: mmotm 2011-01-25-15-47 uploaded] Jiri Slaby
2011-02-03  7:53   ` Eric Dumazet
2011-02-03  9:03     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110126111602.7bfea64e.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=rpurdie@rpsys.net \
    --subject='Re: [PATCH -mmotm] backlight: apple_bl depends on ACPI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).