LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kacper Kornet <kornet@camk.edu.pl>
To: linux-kernel@vger.kernel.org
Cc: Jiri Slaby <jslaby@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] Fix prlimit64 for suid/sgid processes
Date: Thu, 27 Jan 2011 14:47:10 +0100	[thread overview]
Message-ID: <20110127134710.GB519@camk.edu.pl> (raw)

Since check_prlimit_permission always fails in the case of SUID/GUID
processes, such processes are not able to read or set their own limits.
This commit changes this by assuming that process can always read/change
its own limits.

Signed-off-by: Kacper Kornet <kornet@camk.edu.pl>
---
 kernel/sys.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index e9ad444..0aaafde 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1409,10 +1409,12 @@ SYSCALL_DEFINE4(prlimit64, pid_t, pid, unsigned int, resource,
 		rcu_read_unlock();
 		return -ESRCH;
 	}
-	ret = check_prlimit_permission(tsk);
-	if (ret) {
-		rcu_read_unlock();
-		return ret;
+	if (tsk != current) {
+		ret = check_prlimit_permission(tsk);
+		if (ret) {
+			rcu_read_unlock();
+			return ret;
+		}
 	}
 	get_task_struct(tsk);
 	rcu_read_unlock();
-- 
  Kacper Kornet

             reply	other threads:[~2011-01-27 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 13:47 Kacper Kornet [this message]
2011-01-27 22:59 ` Linus Torvalds
2011-01-28 23:21   ` [PATCH v2] " Kacper Kornet
2011-01-28 23:28     ` Jiri Slaby
2011-01-31  9:40     ` [for .36,.37 stable] " Jiri Slaby
2011-02-15 14:28       ` [stable] [for .36, .37 " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110127134710.GB519@camk.edu.pl \
    --to=kornet@camk.edu.pl \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] Fix prlimit64 for suid/sgid processes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).