LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Joel Becker <jlbec@evilplan.org>
Cc: dsterba@suse.cz, mfasheh@suse.com, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock
Date: Thu, 27 Jan 2011 17:48:57 -0800	[thread overview]
Message-ID: <20110127174857.1f49cefc.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110128013552.GB8019@noexit>

On Thu, 27 Jan 2011 17:35:53 -0800 Joel Becker <jlbec@evilplan.org> wrote:

> > --- a/fs/ocfs2/dlm/dlmdomain.c~a
> > +++ a/fs/ocfs2/dlm/dlmdomain.c
> > @@ -926,9 +926,9 @@ static int dlm_assert_joined_handler(str
> >  }
> >  
> >  static int dlm_match_regions(struct dlm_ctxt *dlm,
> > -			     struct dlm_query_region *qr)
> > +			     struct dlm_query_region *qr, u8 *local)
> >  {
> > -	char *local = NULL, *remote = qr->qr_regions;
> > +	char *remote = qr->qr_regions;
> 
> 	Won't the stack-depth busybodies hate us for this?  I realize we
> don't go much deeper from here, but it still is 1K of stack.

+	static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */
        ^^^^^^

  reply	other threads:[~2011-01-28  1:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 22:36 David Sterba
2010-11-18 23:42 ` Joel Becker
2011-01-28  1:09 ` Andrew Morton
2011-01-28  1:28   ` [Ocfs2-devel] " Sunil Mushran
2011-01-28  1:48     ` Andrew Morton
2011-01-28  1:35   ` Joel Becker
2011-01-28  1:48     ` Andrew Morton [this message]
2011-01-28  2:33       ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110127174857.1f49cefc.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dsterba@suse.cz \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --subject='Re: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).