From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603Ab1A1Cds (ORCPT ); Thu, 27 Jan 2011 21:33:48 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:60563 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754495Ab1A1Cdr (ORCPT ); Thu, 27 Jan 2011 21:33:47 -0500 Date: Thu, 27 Jan 2011 18:33:42 -0800 From: Joel Becker To: Andrew Morton Cc: dsterba@suse.cz, mfasheh@suse.com, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] fs/ocfs2/dlm: Use GFP_ATOMIC under spin_lock Message-ID: <20110128023341.GA9816@noexit> Mail-Followup-To: Andrew Morton , dsterba@suse.cz, mfasheh@suse.com, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com References: <20101102223601.GA27513@ds.suse.cz> <20110127170948.9a0d8b60.akpm@linux-foundation.org> <20110128013552.GB8019@noexit> <20110127174857.1f49cefc.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110127174857.1f49cefc.akpm@linux-foundation.org> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2011 at 05:48:57PM -0800, Andrew Morton wrote: > On Thu, 27 Jan 2011 17:35:53 -0800 Joel Becker wrote: > > > > --- a/fs/ocfs2/dlm/dlmdomain.c~a > > > +++ a/fs/ocfs2/dlm/dlmdomain.c > > > @@ -926,9 +926,9 @@ static int dlm_assert_joined_handler(str > > > } > > > > > > static int dlm_match_regions(struct dlm_ctxt *dlm, > > > - struct dlm_query_region *qr) > > > + struct dlm_query_region *qr, u8 *local) > > > { > > > - char *local = NULL, *remote = qr->qr_regions; > > > + char *remote = qr->qr_regions; > > > > Won't the stack-depth busybodies hate us for this? I realize we > > don't go much deeper from here, but it still is 1K of stack. > > + static u8 local[sizeof(qr->qr_regions)]; /* locked by dlm_domain_lock */ > ^^^^^^ I can read C, I swear! Joel -- "And yet I find, And yet I find repeating in my head. If I can't be my own, I'd feel better dead." http://www.jlbec.org/ jlbec@evilplan.org