LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Vipin Mehta <vmehta@atheros.com>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL
Date: Fri, 28 Jan 2011 14:42:15 +0300 [thread overview]
Message-ID: <20110128114214.GD20606@bicker> (raw)
In-Reply-To: <3a5cf32b0de8cd3153d385e2198d7aa4c787697e.1296186677.git.joe@perches.com>
On Thu, Jan 27, 2011 at 08:04:29PM -0800, Joe Perches wrote:
> - A_UINT8 is_amsdu, tid, is_acl_data_frame;
> + A_BOOL is_amsdu;
> + A_UINT8 tid;
> + A_BOOL is_acl_data_frame;
Just use bool for bool and u8 for u8. It's not reasonable for everyone
to rename basic types for every driver. (Unless Atheros bool really is
different from other people's bool then it would be totally reasonable).
regards,
dan carpenter
next prev parent reply other threads:[~2011-01-28 11:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 4:04 [git pull-request and PATCH 00/15] staging: ath6kl: Cleanups Joe Perches
2011-01-28 4:04 ` [PATCH 01/15] staging: ath6kl: Update cfg80211 to recent calling convention changes Joe Perches
2011-01-28 7:35 ` Dan Carpenter
2011-01-28 7:41 ` Dan Carpenter
2011-01-28 4:04 ` [PATCH 02/15] staging: ath6kl: Convert enum A_STATUS to int Joe Perches
2011-01-28 4:04 ` [PATCH 03/15] staging: ath6kl: Remove A_SUCCESS macro Joe Perches
2011-01-28 4:04 ` [PATCH 04/15] staging: ath6kl: Remove A_FAILED macro Joe Perches
2011-01-28 4:04 ` [PATCH 06/15] staging: ath6kl: Convert bypasswmi to bool Joe Perches
2011-01-28 4:04 ` [PATCH 07/15] staging: ath6kl: Convert type of streamExists to A_UINT8 Joe Perches
2011-01-28 4:04 ` [PATCH 08/15] staging: ath6kl: Convert BDADDR_Present uses to TRUE/FALSE bugfix Joe Perches
2011-01-28 4:04 ` [PATCH 09/15] staging: ath6kl: Convert A_BOOL compressed sets from 0 to FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 10/15] staging: ath6kl: Convert " Joe Perches
2011-01-28 4:04 ` [PATCH 11/15] staging: ath6kl: cfg80211: Convert forceFgScan to A_UINT32 Joe Perches
2011-01-28 4:04 ` [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL Joe Perches
2011-01-28 11:42 ` Dan Carpenter [this message]
2011-01-28 15:45 ` Joe Perches
2011-01-28 4:04 ` [PATCH 13/15] staging: ath6kl: Convert A_NETBUF_QUEUE_EMPTY to return TRUE or FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 14/15] staging: ath6kl: Convert sets of scanSpecificSsid to TRUE/FALSE Joe Perches
2011-01-28 4:04 ` [PATCH 15/15] staging: ath6kl: Convert tspecCompliance from A_BOOL to int Joe Perches
[not found] ` <d1deb8a42497651898ad03bda9018d9deca93f12.1296186677.git.joe@perches.com>
2011-01-28 6:22 ` [PATCH 05/15] staging: ath6kl: wmi.h: Convert packed structures with A_BOOL to u32 Denis Kirjanov
2011-01-28 19:47 ` [git pull-request and PATCH 00/15] staging: ath6kl: Cleanups Vipin Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128114214.GD20606@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vmehta@atheros.com \
--subject='Re: [PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).