LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data
@ 2011-01-27 13:47 Manjunathappa, Prakash
2011-01-27 20:42 ` [alsa-devel] " Liam Girdwood
2011-01-28 12:25 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Manjunathappa, Prakash @ 2011-01-27 13:47 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: alsa-devel, davinci-linux-open-source, linux-arm-kernel, stable,
linux-kernel, Manjunathappa, Prakash
This patch fixes the Kernel panic issue on accessing davinci_vc in
cq93vc_probe function. struct davinci_vc is part of platform device's
private driver data(codec->dev->p->driver_data) and this is populated
by DaVinci Voice Codec MFD driver.
Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
---
This patch applies to Linus's tree at [1].
[1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
---
sound/soc/codecs/cq93vc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 46dbfd0..347a567 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -153,7 +153,7 @@ static int cq93vc_resume(struct snd_soc_codec *codec)
static int cq93vc_probe(struct snd_soc_codec *codec)
{
- struct davinci_vc *davinci_vc = codec->dev->platform_data;
+ struct davinci_vc *davinci_vc = snd_soc_codec_get_drvdata(codec);
davinci_vc->cq93vc.codec = codec;
codec->control_data = davinci_vc;
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data
2011-01-27 13:47 [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data Manjunathappa, Prakash
@ 2011-01-27 20:42 ` Liam Girdwood
2011-01-28 12:25 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-01-27 20:42 UTC (permalink / raw)
To: Manjunathappa, Prakash
Cc: Mark Brown, davinci-linux-open-source, alsa-devel, linux-kernel,
stable, linux-arm-kernel
On Thu, 2011-01-27 at 19:17 +0530, Manjunathappa, Prakash wrote:
> This patch fixes the Kernel panic issue on accessing davinci_vc in
> cq93vc_probe function. struct davinci_vc is part of platform device's
> private driver data(codec->dev->p->driver_data) and this is populated
> by DaVinci Voice Codec MFD driver.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> ---
> This patch applies to Linus's tree at [1].
>
> [1] http://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> ---
> sound/soc/codecs/cq93vc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
> index 46dbfd0..347a567 100644
> --- a/sound/soc/codecs/cq93vc.c
> +++ b/sound/soc/codecs/cq93vc.c
> @@ -153,7 +153,7 @@ static int cq93vc_resume(struct snd_soc_codec *codec)
>
> static int cq93vc_probe(struct snd_soc_codec *codec)
> {
> - struct davinci_vc *davinci_vc = codec->dev->platform_data;
> + struct davinci_vc *davinci_vc = snd_soc_codec_get_drvdata(codec);
>
> davinci_vc->cq93vc.codec = codec;
> codec->control_data = davinci_vc;
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data
2011-01-27 13:47 [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data Manjunathappa, Prakash
2011-01-27 20:42 ` [alsa-devel] " Liam Girdwood
@ 2011-01-28 12:25 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-01-28 12:25 UTC (permalink / raw)
To: Manjunathappa, Prakash
Cc: Liam Girdwood, alsa-devel, davinci-linux-open-source,
linux-arm-kernel, stable, linux-kernel
On Thu, Jan 27, 2011 at 07:17:43PM +0530, Manjunathappa, Prakash wrote:
> This patch fixes the Kernel panic issue on accessing davinci_vc in
> cq93vc_probe function. struct davinci_vc is part of platform device's
> private driver data(codec->dev->p->driver_data) and this is populated
> by DaVinci Voice Codec MFD driver.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-28 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-27 13:47 [PATCH] ASoC: DaVinci: fix kernel panic due to uninitialized platform_data Manjunathappa, Prakash
2011-01-27 20:42 ` [alsa-devel] " Liam Girdwood
2011-01-28 12:25 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).