LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Fix prlimit64 for suid/sgid processes
@ 2011-01-27 13:47 Kacper Kornet
  2011-01-27 22:59 ` Linus Torvalds
  0 siblings, 1 reply; 6+ messages in thread
From: Kacper Kornet @ 2011-01-27 13:47 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jiri Slaby, Linus Torvalds

Since check_prlimit_permission always fails in the case of SUID/GUID
processes, such processes are not able to read or set their own limits.
This commit changes this by assuming that process can always read/change
its own limits.

Signed-off-by: Kacper Kornet <kornet@camk.edu.pl>
---
 kernel/sys.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index e9ad444..0aaafde 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1409,10 +1409,12 @@ SYSCALL_DEFINE4(prlimit64, pid_t, pid, unsigned int, resource,
 		rcu_read_unlock();
 		return -ESRCH;
 	}
-	ret = check_prlimit_permission(tsk);
-	if (ret) {
-		rcu_read_unlock();
-		return ret;
+	if (tsk != current) {
+		ret = check_prlimit_permission(tsk);
+		if (ret) {
+			rcu_read_unlock();
+			return ret;
+		}
 	}
 	get_task_struct(tsk);
 	rcu_read_unlock();
-- 
  Kacper Kornet

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-02-15 16:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-27 13:47 [PATCH] Fix prlimit64 for suid/sgid processes Kacper Kornet
2011-01-27 22:59 ` Linus Torvalds
2011-01-28 23:21   ` [PATCH v2] " Kacper Kornet
2011-01-28 23:28     ` Jiri Slaby
2011-01-31  9:40     ` [for .36,.37 stable] " Jiri Slaby
2011-02-15 14:28       ` [stable] [for .36, .37 " Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).