LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] soc: neo1973_wm8753 audio support does not require scoop
@ 2011-01-28 19:00 H Hartley Sweeten
2011-01-31 11:23 ` [alsa-devel] " Mark Brown
2011-01-31 13:36 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-01-28 19:00 UTC (permalink / raw)
To: Linux Kernel; +Cc: alsa-devel
This driver does not use any of the functionality provided by the scoop
hardware. Remove the unneeded header.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
index c7a2451..c5b3113 100644
--- a/sound/soc/samsung/neo1973_wm8753.c
+++ b/sound/soc/samsung/neo1973_wm8753.c
@@ -24,7 +24,6 @@
#include <sound/tlv.h>
#include <asm/mach-types.h>
-#include <asm/hardware/scoop.h>
#include <mach/regs-clock.h>
#include <mach/regs-gpio.h>
#include <mach/hardware.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] soc: neo1973_wm8753 audio support does not require scoop
2011-01-28 19:00 [PATCH] soc: neo1973_wm8753 audio support does not require scoop H Hartley Sweeten
@ 2011-01-31 11:23 ` Mark Brown
2011-01-31 12:05 ` Liam Girdwood
2011-01-31 13:36 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-01-31 11:23 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, alsa-devel, lrg
On Fri, Jan 28, 2011 at 12:00:18PM -0700, H Hartley Sweeten wrote:
> This driver does not use any of the functionality provided by the scoop
> hardware. Remove the unneeded header.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
CCing in Liam. As I think I've mentioned before please do remember to
CC maintainers.
>
> ---
>
> diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
> index c7a2451..c5b3113 100644
> --- a/sound/soc/samsung/neo1973_wm8753.c
> +++ b/sound/soc/samsung/neo1973_wm8753.c
> @@ -24,7 +24,6 @@
> #include <sound/tlv.h>
>
> #include <asm/mach-types.h>
> -#include <asm/hardware/scoop.h>
> #include <mach/regs-clock.h>
> #include <mach/regs-gpio.h>
> #include <mach/hardware.h>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] soc: neo1973_wm8753 audio support does not require scoop
2011-01-31 11:23 ` [alsa-devel] " Mark Brown
@ 2011-01-31 12:05 ` Liam Girdwood
0 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-01-31 12:05 UTC (permalink / raw)
To: Mark Brown; +Cc: H Hartley Sweeten, alsa-devel, Linux Kernel
On Mon, 2011-01-31 at 11:23 +0000, Mark Brown wrote:
> On Fri, Jan 28, 2011 at 12:00:18PM -0700, H Hartley Sweeten wrote:
> > This driver does not use any of the functionality provided by the scoop
> > hardware. Remove the unneeded header.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> CCing in Liam. As I think I've mentioned before please do remember to
> CC maintainers.
>
> >
> > ---
> >
> > diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c
> > index c7a2451..c5b3113 100644
> > --- a/sound/soc/samsung/neo1973_wm8753.c
> > +++ b/sound/soc/samsung/neo1973_wm8753.c
> > @@ -24,7 +24,6 @@
> > #include <sound/tlv.h>
> >
> > #include <asm/mach-types.h>
> > -#include <asm/hardware/scoop.h>
> > #include <mach/regs-clock.h>
> > #include <mach/regs-gpio.h>
> > #include <mach/hardware.h>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: neo1973_wm8753 audio support does not require scoop
2011-01-28 19:00 [PATCH] soc: neo1973_wm8753 audio support does not require scoop H Hartley Sweeten
2011-01-31 11:23 ` [alsa-devel] " Mark Brown
@ 2011-01-31 13:36 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-01-31 13:36 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, alsa-devel
On Fri, Jan 28, 2011 at 12:00:18PM -0700, H Hartley Sweeten wrote:
> This driver does not use any of the functionality provided by the scoop
> hardware. Remove the unneeded header.
Applied but please in future remember to:
- Send copies of your patches to the relevant maintainers as documented
in Documentation/SubmittingPatches so maintainers actually see them.
- Make your commit messages match the style for the subsystem you're
submitting to.
This stuff is especially important for minor cleanups like this, please
do try to bear it in mind.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-31 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-28 19:00 [PATCH] soc: neo1973_wm8753 audio support does not require scoop H Hartley Sweeten
2011-01-31 11:23 ` [alsa-devel] " Mark Brown
2011-01-31 12:05 ` Liam Girdwood
2011-01-31 13:36 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).