From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755193Ab1AaOLw (ORCPT ); Mon, 31 Jan 2011 09:11:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404Ab1AaOLu (ORCPT ); Mon, 31 Jan 2011 09:11:50 -0500 Date: Mon, 31 Jan 2011 15:02:57 +0100 From: Oleg Nesterov To: Daniel Lezcano Cc: akpm@linux-foundation.org, ebiederm@xmission.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, clg@fr.ibm.com Subject: Re: [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Message-ID: <20110131140257.GA28827@redhat.com> References: <1296469525-30111-1-git-send-email-daniel.lezcano@free.fr> <1296469525-30111-3-git-send-email-daniel.lezcano@free.fr> <20110131132207.GA26995@redhat.com> <4D46BA25.8080201@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D46BA25.8080201@free.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31, Daniel Lezcano wrote: > > On 01/31/2011 02:22 PM, Oleg Nesterov wrote: >> On 01/31, Daniel Lezcano wrote: >>> @@ -96,6 +97,9 @@ static struct pid_namespace *create_pid_namespace(struct pid_namespace *parent_p >>> for (i = 1; i< PIDMAP_ENTRIES; i++) >>> atomic_set(&ns->pidmap[i].nr_free, BITS_PER_PAGE); >>> >>> + if (pid_ns_prepare_proc(ns)) >>> + goto out_free_map; >>> + >>> return ns; >> This is not right, afaics. I already sent the similar patches, but >> they were ignored ;) >> >> Please see http://marc.info/?l=linux-kernel&m=127697484000334 >> >> If pid_ns_prepare_proc() fails we shouldn't blindly return ENOMEM >> and, more importantly, we need put_pid_ns(parent_ns). > > Oh, ok. Right. Thanks for the pointer. > > Are you ok if I replace the patch 2/4 with your patch ? My patch depends on 1/4, http://marc.info/?l=linux-kernel&m=127697468632667 Your change looks very similar to 1/4 + 3/4. Just fix the problem in create_pid_namespace(), no need to replace. Oleg.