LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: hancockrwd@gmail.com
Cc: fujita.tomonori@lab.ntt.co.jp, ak@linux.intel.com,
cebbert@redhat.com, linux-kernel@vger.kernel.org,
dwmw2@infradead.org
Subject: Re: b44 driver causes panic when using swiotlb
Date: Tue, 1 Feb 2011 14:22:01 +0900 [thread overview]
Message-ID: <20110201142103M.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <4D477C6F.8000906@gmail.com>
On Mon, 31 Jan 2011 21:22:23 -0600
Robert Hancock <hancockrwd@gmail.com> wrote:
> > Some ideas to implement something that works for such device were
> > discussed. Seems that the conclusion is that it's doesn't worth making
> > the common code complicated for such minor and insane devices.
>
> I don't think this is the only device that has sub-32-bit DMA
> restrictions, this will just lead to a bunch of duplicated code.
Yeah, not only device but not many.
The block layer has the own bouncing mechanism. Some network drivers
have the similar bouncing code. I don't know if there are other kinds
of drivers that have the own bouncing code.
I thought that we can make mm/bounce.c (used for block drivers now)
work any drivers without complicating it. We could make swiotlb to do
but it's too complicated and it doesn't worth.
> In
> particular, how is LPC DMA supposed to work?
LPC DMA can't do 32bit dma?
> At the very least we should be allowing the driver to deal with the
> failure instead of panicing the system. Otherwise we are just leaving a
> land mine for people to trip over.
Agreed. swiotlb shouldn't panic in this case. I'll take care of it.
next prev parent reply other threads:[~2011-02-01 5:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 15:54 Chuck Ebbert
2011-01-31 16:36 ` Andi Kleen
2011-02-01 0:54 ` Robert Hancock
2011-02-01 1:28 ` FUJITA Tomonori
2011-02-01 3:22 ` Robert Hancock
2011-02-01 5:22 ` FUJITA Tomonori [this message]
2011-02-15 0:47 ` Robert Hancock
2011-02-01 21:18 ` Chuck Ebbert
2011-02-02 0:06 ` FUJITA Tomonori
2011-02-02 0:09 ` FUJITA Tomonori
2011-02-01 18:07 ` Andi Kleen
2011-02-01 21:44 ` Robert Hancock
2011-02-01 13:54 ` FUJITA Tomonori
2011-02-14 11:59 ` FUJITA Tomonori
2011-02-14 16:41 ` Arkadiusz Miśkiewicz
2011-02-15 0:39 ` FUJITA Tomonori
2011-02-15 22:03 ` Chuck Ebbert
[not found] <4D478EDC.4070004@lwfinger.net>
2011-02-01 4:53 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201142103M.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=ak@linux.intel.com \
--cc=cebbert@redhat.com \
--cc=dwmw2@infradead.org \
--cc=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: b44 driver causes panic when using swiotlb' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).