LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* tcp_ecn is an integer not a boolean
@ 2011-02-02 22:49 Peter Chubb
  2011-02-02 23:40 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Chubb @ 2011-02-02 22:49 UTC (permalink / raw)
  To: trivial; +Cc: linux-kernel


There was some confusion at LCA as to why the sysctl tcp_ecn took one
of three values when it was documented as a Boolean.  This patch fixes
the documentation.

Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index d99940d..ac3b4a7 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
 tcp_dsack - BOOLEAN
 	Allows TCP to send "duplicate" SACKs.
 
-tcp_ecn - BOOLEAN
+tcp_ecn - INTEGER
 	Enable Explicit Congestion Notification (ECN) in TCP. ECN is only
 	used when both ends of the TCP flow support it. It is useful to
 	avoid losses due to congestion (when the bottleneck router supports

--
Dr Peter Chubb                                  peter DOT chubb AT nicta.com.au
http://www.ertos.nicta.com.au               ERTOS within National ICT Australia
All things shall perish from under the sky/Music alone shall live, never to die

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tcp_ecn is an integer not a boolean
  2011-02-02 22:49 tcp_ecn is an integer not a boolean Peter Chubb
@ 2011-02-02 23:40 ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2011-02-02 23:40 UTC (permalink / raw)
  To: peter.chubb; +Cc: trivial, linux-kernel

From: Peter Chubb <peter.chubb@nicta.com.au>
Date: Thu, 03 Feb 2011 09:49:08 +1100

> 
> There was some confusion at LCA as to why the sysctl tcp_ecn took one
> of three values when it was documented as a Boolean.  This patch fixes
> the documentation.
> 
> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>

Applied, thanks Peter.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tcp_ecn is an integer not a boolean
  2011-02-03 21:35   ` David Miller
@ 2011-02-03 21:45     ` Jiri Kosina
  0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2011-02-03 21:45 UTC (permalink / raw)
  To: David Miller; +Cc: peter.chubb, linux-kernel

On Thu, 3 Feb 2011, David Miller wrote:

> >> There was some confusion at LCA as to why the sysctl tcp_ecn took one
> >> of three values when it was documented as a Boolean.  This patch fixes
> >> the documentation.
> >> 
> >> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
> >> 
> >> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> >> index d99940d..ac3b4a7 100644
> >> --- a/Documentation/networking/ip-sysctl.txt
> >> +++ b/Documentation/networking/ip-sysctl.txt
> >> @@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
> >>  tcp_dsack - BOOLEAN
> >>  	Allows TCP to send "duplicate" SACKs.
> >>  
> >> -tcp_ecn - BOOLEAN
> >> +tcp_ecn - INTEGER
> > 
> > Applied, thanks.
> 
> There is no need, did you see my reply?  I put it into the net-2.6
> GIT tree already.

Ah, no, I haven't, because Peter apparently originaly sent it to ancient 
trivial@rustcorp.com.au and only then bounced it to proper address, but 
your followup went to the old one as well.

OK, I will drop it, thanks for letting me know.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tcp_ecn is an integer not a boolean
  2011-02-03 10:26 ` Jiri Kosina
@ 2011-02-03 21:35   ` David Miller
  2011-02-03 21:45     ` Jiri Kosina
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-02-03 21:35 UTC (permalink / raw)
  To: jkosina; +Cc: peter.chubb, linux-kernel

From: Jiri Kosina <jkosina@suse.cz>
Date: Thu, 3 Feb 2011 11:26:57 +0100 (CET)

> On Thu, 3 Feb 2011, Peter Chubb wrote:
> 
>> 
>> There was some confusion at LCA as to why the sysctl tcp_ecn took one
>> of three values when it was documented as a Boolean.  This patch fixes
>> the documentation.
>> 
>> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
>> 
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index d99940d..ac3b4a7 100644
>> --- a/Documentation/networking/ip-sysctl.txt
>> +++ b/Documentation/networking/ip-sysctl.txt
>> @@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
>>  tcp_dsack - BOOLEAN
>>  	Allows TCP to send "duplicate" SACKs.
>>  
>> -tcp_ecn - BOOLEAN
>> +tcp_ecn - INTEGER
> 
> Applied, thanks.

There is no need, did you see my reply?  I put it into the net-2.6
GIT tree already.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: tcp_ecn is an integer not a boolean
       [not found] <w4vd12m4it.wl%peter@chubb.wattle.id.au>
@ 2011-02-03 10:26 ` Jiri Kosina
  2011-02-03 21:35   ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2011-02-03 10:26 UTC (permalink / raw)
  To: Peter Chubb; +Cc: linux-kernel

On Thu, 3 Feb 2011, Peter Chubb wrote:

> 
> There was some confusion at LCA as to why the sysctl tcp_ecn took one
> of three values when it was documented as a Boolean.  This patch fixes
> the documentation.
> 
> Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
> 
> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
> index d99940d..ac3b4a7 100644
> --- a/Documentation/networking/ip-sysctl.txt
> +++ b/Documentation/networking/ip-sysctl.txt
> @@ -187,7 +187,7 @@ tcp_cookie_size - INTEGER
>  tcp_dsack - BOOLEAN
>  	Allows TCP to send "duplicate" SACKs.
>  
> -tcp_ecn - BOOLEAN
> +tcp_ecn - INTEGER

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-02-03 21:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-02 22:49 tcp_ecn is an integer not a boolean Peter Chubb
2011-02-02 23:40 ` David Miller
     [not found] <w4vd12m4it.wl%peter@chubb.wattle.id.au>
2011-02-03 10:26 ` Jiri Kosina
2011-02-03 21:35   ` David Miller
2011-02-03 21:45     ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).